MapCss stop loading rule on unknown instruction

[frodrigo]

On the goal of sharing validation between JOSM and Osmose-QA I have implemented MapCSS support into Osmose-QA. Osmose-QA rules may now be written in MapCSS, or converted to MapCSS.
Now I want to move to the next step, share Osmose-QA MapCSS files with JOSM.
On Osmose-QA I have add two "proprietaries" instructions: osmoseItemClassLevel and osmoseTags.
But JOSM fails load rules when it found an unknown instruction.

2018-11-30 22:06:45.846 INFO: Adding /../home/fred/tmp/osmose-backend/plugins/Bicycle.validator.mapcss to tag checker
2018-11-30 22:06:45.854 SEVERE: Cannot add MapCss rule: Cannot add instruction osmoseItemClassLevel: 4030/40301/2!

Osmose-QA MapCSS rules look like:

way[highway=cycleway][cycleway=track] {
    throwWarning: tr("{0} with {1}", "{0.tag}", "{1.tag}");
    osmoseItemClassLevel: "3032/30328/2";
    osmoseTags: list("tag", "highway", "cycleway");
    fixRemove: "cycleway";
}

[stoecker]

Maybe we should follow CSS and have arguments starting with "-" (i.e. -webkit-border-image) as private extensions and ignore them?

That would mean you need to rename them to -osmoseTags and we would need to ignore them.

I wouldn't generally open the checks - this will produce too many bad files.

[frodrigo]

Yes it's a good idea. I'm open to rename in all existing Osmose MapCSS files.

[Don-vip]

Sounds good.

[Don-vip]

In 14481/josm:

fix #17053 - ignore MapCSS declarations starting with "-" to allow external extensions (used by osmose)

[Klumbumbus]

After next stable release wiki:/Rules/SuspiciousSwimming_Pool should be reverted to version 7.

[Don-vip]

Replying to Klumbumbus:

After next stable release wiki:/Rules/SuspiciousSwimming_Pool should be reverted to version 7.

Yes but the new declarations must be prefixed by "-".

[Don-vip]

In 14489/josm:

see #17053 - fix parsing regression involving the - operator

[Klumbumbus]

Replying to Don-vip:

Replying to Klumbumbus:

After next stable release wiki:/Rules/SuspiciousSwimming_Pool should be reverted to version 7.

Yes but the new declarations must be prefixed by "-".

Changes were done.