Opened 5 years ago

Closed 5 years ago

#17046 closed defect (othersoftware)

Seamark validator wrong positive on cevni sign A5.1 (no_berthing_lateral_limit)

Reported by: AdVerburg Owned by: team
Priority: normal Milestone:
Component: External rule Version:
Keywords: template_report github Cc:


What steps will reproduce the problem?

  1. Make sure "Seamark Validation Rules by Aun (Skippern) Johnsen" is active
  2. Insert a node with: seamark:notice:category=no_berthing_lateral_limit seamark:notice:function=prohibition seamark:notice:system=cevni seamark:type=notice
  3. Hit the validation button.

What is the expected result?

No warning.

What happens instead?

A warning (shortened): "In cevni seamark:notice:category=entry_permitted|…|berthing_permitted|berthing_lateral_limit|berthing_lateral_limits|berthing_rafting_limit|berthing_unmarked_pushing|…|waterbikes_permitted require seamark:notice:function=information (1)"

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-11-28 01:09:01 +0100 (Wed, 28 Nov 2018)
Build-Date:2018-11-28 00:26:41

Identification: JOSM/1.5 (14460 en_GB) Linux openSUSE Tumbleweed
Memory Usage: 336 MB / 1974 MB (145 MB allocated, but free)
Java version: 11.0.1+13-suse-2.1-x8664, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: java-11-openjdk:x86_64-
Dataset consistency test: No problems found

+ Mapillary (v1.5.17)
+ PicLayer (34544)
+ SeaChart (34237)
+ SeaMapEditor (34589)
+ apache-commons (34506)
+ apache-http (34632)
+ ejml (34389)
+ geojson (87)
+ geotools (34513)
+ jaxb (34506)
+ jna (34633)
+ jts (34524)
+ measurement (34529)
+ opendata (34698)
+ reverter (34552)
+ turnrestrictions (34643)
+ utilsplugin2 (34506)

Tagging presets:
+ <josm.pref>/Beacons.xml
+ <josm.pref>/PTstops.xml

Map paint styles:

Validator rules:

Last errors/warnings:
- W: Unknown setting type: integer
- W: Unknown setting type: integer
- W: Unknown setting type: integer
- W: No configuration settings found.  Using hardcoded default values for all pools.

In the validator is checked with "~" (meaning like) on "no_berthing_lateral_limit" with the function prohibition, this passes.
However a few lines later with the function information the check with "~" on "berthing_lateral_limit" triggers the false positive, because "no_berthing_lateral_limit" looks like "berthing_lateral_limit" (the tag-value for cevni E5.1).

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by Klumbumbus

Component: CoreExternal rule
Keywords: github added
Resolution: othersoftware
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.