﻿id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
17046	Seamark validator wrong positive on cevni sign A5.1 (no_berthing_lateral_limit)	AdVerburg	team	"==== What steps will reproduce the problem?
1. Make sure ""Seamark Validation Rules by Aun (Skippern) Johnsen"" is active
2. Insert a node with:
   seamark:notice:category=no_berthing_lateral_limit
   seamark:notice:function=prohibition
   seamark:notice:system=cevni
   seamark:type=notice
3. Hit the validation button.

==== What is the expected result?
No warning.

==== What happens instead?
A warning (shortened): ""In cevni seamark:notice:category=entry_permitted|…|berthing_permitted|berthing_lateral_limit|berthing_lateral_limits|berthing_rafting_limit|berthing_unmarked_pushing|…|waterbikes_permitted require seamark:notice:function=information (1)""

==== Please provide any additional information below. Attach a screenshot if possible.

{{{
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-11-28 01:09:01 +0100 (Wed, 28 Nov 2018)
Revision:14460
Build-Date:2018-11-28 00:26:41
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14460 en_GB) Linux openSUSE Tumbleweed
Memory Usage: 336 MB / 1974 MB (145 MB allocated, but free)
Java version: 11.0.1+13-suse-2.1-x8664, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: java-11-openjdk:x86_64-11.0.1.0
Dataset consistency test: No problems found

Plugins:
+ Mapillary (v1.5.17)
+ PicLayer (34544)
+ SeaChart (34237)
+ SeaMapEditor (34589)
+ apache-commons (34506)
+ apache-http (34632)
+ ejml (34389)
+ geojson (87)
+ geotools (34513)
+ jaxb (34506)
+ jna (34633)
+ jts (34524)
+ measurement (34529)
+ opendata (34698)
+ reverter (34552)
+ turnrestrictions (34643)
+ utilsplugin2 (34506)

Tagging presets:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Presets_Hafen.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenSeaMap_bridge&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ <josm.pref>/Beacons.xml
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip
+ <josm.pref>/PTstops.xml
+ https://raw.githubusercontent.com/OpenSeaMap/josm/master/Presets_Sport.xml

Map paint styles:
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
+ https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
- https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT1_MapCSS.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
+ http://duinoord.home.xs4all.nl/OSM/JOSM/NL_traffic_signs/Styles_Traffic_signs-style.mapcss
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip

Validator rules:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- W: Unknown setting type: integer
- W: Unknown setting type: integer
- W: Unknown setting type: integer
- W: No configuration settings found.  Using hardcoded default values for all pools.
}}}
------------------------
In the validator is checked with ""~"" (meaning like) on ""no_berthing_lateral_limit"" with the function prohibition, this passes. 
However a few lines later with the function information the check with ""~"" on ""berthing_lateral_limit"" triggers the false positive, because ""no_berthing_lateral_limit"" looks like ""berthing_lateral_limit"" (the tag-value for cevni E5.1)."	defect	closed	normal		External rule		othersoftware	template_report github	
