Modify

Opened 6 years ago

Last modified 2 years ago

#17014 new enhancement

"produce" key

Reported by: naoliv Owned by: naoliv
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: crop produce Cc:

Description (last modified by naoliv)

Do you prefer to ignore produce

  • data/validator/ignoretags.cfg

    diff --git a/data/validator/ignoretags.cfg b/data/validator/ignoretags.cfg
    index 3704c25d0..969f4fa81 100644
    a b E:capacity  
    120120E:cables
    121121E:circuits
    122122E:direction
     123E:produce
    123124;
    124125; Ignore valid and semi-valid keys that end with...
    125126;

or to have something similar to this in the presets?

  • data/defaultpresets.xml

    diff --git a/data/defaultpresets.xml b/data/defaultpresets.xml
    index 51e71dc38..320d509e3 100644
    a b  
    1136911369                  uk.href="https://wiki.openstreetmap.org/wiki/Uk:Tag:landuse=forest" />
    1137011370            <space />
    1137111371            <key key="landuse" value="forest" />
     11372            <optional>
     11373                <combo key="produce" text="Produce" values="christmas_trees,cork,fire_wood,latex,maple_syrup,oil,timber" />
     11374            </optional>
    1137211375            <reference ref="leaf" />
    1137311376            <reference ref="optional_name" />
    1137411377        </item> <!-- Forest -->
     
    1159811601                  pt_BR.href="https://wiki.openstreetmap.org/wiki/Pt-br:Tag:landuse=farmland" />
    1159911602            <space />
    1160011603            <key key="landuse" value="farmland" />
    11601             <combo key="crop" text="Crop" values="corn,grass,rice,wheat,hop,tea" values_context="crop" />
     11604            <optional>
     11605                <combo key="crop" text="Crop" values="barley,cereal,corn,grass,potato,rice,rye,soy,sugarcane,tea,tomato,vegetable,wheat" values_context="crop" />
     11606                <combo key="produce" text="Produce" values="barley,cereal,corn,grass,potato,rice,rye,soy,sugarcane,tea,tomato,vegetable,wheat" />
     11607            </optional>
    1160211608            <reference ref="optional_name" />
    1160311609        </item> <!-- Farmland -->
    1160411610        <item name="Meadow" icon="presets/landuse/meadow.svg" type="closedway,multipolygon" preset_name_label="true">
     
    1169811704            <space />
    1169911705            <key key="landuse" value="aquaculture" />
    1170011706            <combo key="aquaculture" text="Aquaculture" values="shrimp,fish,mussels" />
     11707            <optional>
     11708                <combo key="produce" text="Produce" values="crocodile,fish,mussels,oysters,prawns,seaweed,shrimp" />
     11709            </optional>
    1170111710            <reference ref="optional_name_operator" />
    1170211711        </item> <!-- Aquaculture -->
    1170311712        <separator/>

(It seems that I missed orchard, but you got the idea)

Attachments (0)

Change History (13)

comment:1 by naoliv, 6 years ago

Description: modified (diff)

comment:2 by Don-vip, 6 years ago

Milestone: 18.11

I vote for adding it.

comment:3 by Klumbumbus, 6 years ago

Whats the difference between crop and produce when they have the same value? And can they have different values? Having both combos with the same values in the farmland preset looks a bit strange.

comment:4 by Don-vip, 6 years ago

Good point it should only be added to presets not having the information, like aquaculture. We need crocodiles in our presets!

comment:5 by naoliv, 6 years ago

I will rework them and get back with a proper patch.

comment:6 by Don-vip, 5 years ago

Milestone: 18.1118.12

comment:7 by Klumbumbus, 5 years ago

Milestone: 18.1219.01

comment:8 by Don-vip, 5 years ago

Milestone: 19.0119.02

comment:9 by Don-vip, 5 years ago

Milestone: 19.0219.03
Owner: changed from team to naoliv

in reply to:  4 ; comment:10 by Klumbumbus, 5 years ago

Milestone: 19.03

I think this needs some clarification/tagging discussion first ragarding crop vs. produce before we change our preset. There was already a discussion here but without a real result. (I didn't check the mailing lists.) Thus I remove the milestone for now.

Replying to Don-vip:

We need crocodiles in our presets!

Crocodiles are cool but tagged only once so far :(

in reply to:  10 ; comment:11 by Don-vip, 5 years ago

Replying to Klumbumbus:

Crocodiles are cool but tagged only once so far :(

OK I need to see how much the crocodile industry is spread in the world and if we can increase this number :D

comment:12 by Don-vip, 5 years ago

Keywords: crop produce added

in reply to:  11 comment:13 by skyper, 2 years ago

Replying to Don-vip:

Replying to Klumbumbus:

Crocodiles are cool but tagged only once so far :(

OK I need to see how much the crocodile industry is spread in the world and if we can increase this number :D

The production of crocodiles I know have little common with aquaculture and the products are eggs, meat and leather but rarely living animals.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain naoliv.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from naoliv to the specified user.
Next status will be 'needinfo'. The owner will be changed from naoliv to naoliv.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from naoliv to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.