"produce" key

[naoliv]

Do you prefer to ignore ​produce

data/validator/ignoretags.cfg

@@ -120 +120 @@
 E:cables
 E:circuits
 E:direction
+E:produce
 ;
 ; Ignore valid and semi-valid keys that end with...
 ;

or to have something similar to this in the presets?

data/defaultpresets.xml

@@ -11369 +11369 @@
                   uk.href="https://wiki.openstreetmap.org/wiki/Uk:Tag:landuse=forest" />
             <space />
             <key key="landuse" value="forest" />
+            <optional>
+                <combo key="produce" text="Produce" values="christmas_trees,cork,fire_wood,latex,maple_syrup,oil,timber" />
+            </optional>
             <reference ref="leaf" />
             <reference ref="optional_name" />
         </item> <!-- Forest -->
@@ -11598 +11601 @@
                   pt_BR.href="https://wiki.openstreetmap.org/wiki/Pt-br:Tag:landuse=farmland" />
             <space />
             <key key="landuse" value="farmland" />
-            <combo key="crop" text="Crop" values="corn,grass,rice,wheat,hop,tea" values_context="crop" />
+            <optional>
+                <combo key="crop" text="Crop" values="barley,cereal,corn,grass,potato,rice,rye,soy,sugarcane,tea,tomato,vegetable,wheat" values_context="crop" />
+                <combo key="produce" text="Produce" values="barley,cereal,corn,grass,potato,rice,rye,soy,sugarcane,tea,tomato,vegetable,wheat" />
+            </optional>
             <reference ref="optional_name" />
         </item> <!-- Farmland -->
         <item name="Meadow" icon="presets/landuse/meadow.svg" type="closedway,multipolygon" preset_name_label="true">
@@ -11698 +11704 @@
             <space />
             <key key="landuse" value="aquaculture" />
             <combo key="aquaculture" text="Aquaculture" values="shrimp,fish,mussels" />
+            <optional>
+                <combo key="produce" text="Produce" values="crocodile,fish,mussels,oysters,prawns,seaweed,shrimp" />
+            </optional>
             <reference ref="optional_name_operator" />
         </item> <!-- Aquaculture -->
         <separator/>

(It seems that I missed orchard, but you got the idea)

[Don-vip]

I vote for adding it.

[Klumbumbus]

Whats the difference between crop and produce when they have the same value? And can they have different values? Having both combos with the same values in the farmland preset looks a bit strange.

[Don-vip]

Good point it should only be added to presets not having the information, like aquaculture. We need crocodiles in our presets!

[naoliv]

I will rework them and get back with a proper patch.

[Klumbumbus]

I think this needs some clarification/tagging discussion first ragarding crop vs. produce before we change our preset. There was already a discussion ​here but without a real result. (I didn't check the mailing lists.) Thus I remove the milestone for now.

Replying to Don-vip:

We need crocodiles in our presets!

Crocodiles are cool but tagged only ​once so far :(

[Don-vip]

Replying to Klumbumbus:

Crocodiles are cool but tagged only ​once so far :(

OK I need to see how much the crocodile industry is spread in the world and if we can increase this number :D

[skyper]

Replying to Don-vip:

Replying to Klumbumbus:

Crocodiles are cool but tagged only ​once so far :(

OK I need to see how much the crocodile industry is spread in the world and if we can increase this number :D

The production of crocodiles I know have little common with aquaculture and the products are eggs, meat and leather but rarely living animals.