Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#16946 closed enhancement (fixed)

[PATCH] PlatformHookWindows: unbreak tests

Reported by: ris Owned by: team
Priority: normal Milestone: 18.11
Component: Unit tests Version:
Keywords: windows browser openbrowser platform Cc:


r14389 broke a swathe of tests on windows and a few tests on all platforms. I'd really like it if we could get to a place where people didn't merge things that break CI so we don't all have to spend time chasing our tails like this.

Patches against r14408

Change History (6)

comment:1 Changed 20 months ago by Don-vip

This is coming with current infrastructure work, see #16857

comment:2 Changed 20 months ago by Don-vip

Milestone: 18.11
Priority: minornormal

comment:3 Changed 20 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14412/josm:

fix #16946, fix #16947 - unit test fixes for non-headless mode (patch by ris)

comment:4 Changed 20 months ago by Don-vip

Thanks a lot!

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.