Modify ↓

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16946 closed enhancement (fixed)

[PATCH] PlatformHookWindows: unbreak tests

Reported by: ris Owned by: team
Priority: normal Milestone: 18.11
Component: Unit tests Version:
Keywords: windows browser openbrowser platform Cc:

Description

​https://github.com/openstreetmap/josm/pull/51

r14389 broke a swathe of tests on windows and a few tests on all platforms. I'd really like it if we could get to a place where people didn't merge things that break CI so we don't all have to spend time chasing our tails like this.

Patches against r14408

Change History (6)

by ris, 7 years ago

Attachment: v1-0001-PlatformHookWindowsTest-fix-openUrl-test-using-jm.patch​ added

by ris, 7 years ago

Attachment: v1-0002-OpenBrowser-covering-tests-fix-for-windows-throug.patch​ added

comment:1 by Don-vip, 7 years ago

This is coming with current infrastructure work, see #16857

comment:2 by Don-vip, 7 years ago

Milestone: → 18.11
Priority: minor → normal

comment:3 by Don-vip, 7 years ago

Resolution: → fixed
Status: new → closed

In 14412/josm:

fix #16946, fix #16947 - unit test fixes for non-headless mode (patch by ris)

comment:4 by Don-vip, 7 years ago

Thanks a lot!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.