Opened 4 months ago

Closed 2 months ago

#16911 closed defect (fixed)

Some actions stay in redo stack but cannot be redone

Reported by: GerdP Owned by: team
Priority: normal Milestone: 18.12
Component: Core Version:
Keywords: undo regression command stack Cc: GerdP


From ticket:16875#comment:7

There is still something wrong here. Try this:
1) Open sample file raw-attachment/ticket/16875/dupway.osm + run validator
2) Select Building duplicated nodes (4) and click "Fix"
3) Press Ctrl+Z two times
4) Add a new node somewhere else
The new action from 4) is added to the command stack, but the previously "undoned" actions are not removed.
This seems not to depend on the fix action, it also happens during normal edits.

With r13722 I don't see this behaviour.

Attachments (1)

16911-UndoRedo.patch (565 bytes) - added by GerdP 2 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 months ago by GerdP

Cc: GerdP added

comment:2 Changed 3 months ago by Don-vip

Milestone: 18.1118.12

Changed 2 months ago by GerdP

Attachment: 16911-UndoRedo.patch added

comment:3 Changed 2 months ago by GerdP

The attached patch seems to solve the problem but if I got that right ensureTreesConsistency() should do that already, so I'll dig into this again.

comment:4 Changed 2 months ago by GerdP

Resolution: fixed
Status: newclosed

In 14562/josm:

fix #16911 regression from r13729 : make sure that redo tree is cleared when a command is added after one or more undos

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.