Opened 7 years ago
Closed 6 years ago
#16911 closed defect (fixed)
Some actions stay in redo stack but cannot be redone
Reported by: | GerdP | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 18.12 |
Component: | Core | Version: | |
Keywords: | undo regression command stack | Cc: | GerdP |
Description
There is still something wrong here. Try this:
1) Open sample file raw-attachment/ticket/16875/dupway.osm + run validator
2) Select Building duplicated nodes (4) and click "Fix"
3) Press Ctrl+Z two times
4) Add a new node somewhere else
The new action from 4) is added to the command stack, but the previously "undoned" actions are not removed.
This seems not to depend on the fix action, it also happens during normal edits.
With r13722 I don't see this behaviour.
Attachments (1)
Change History (5)
comment:1 by , 7 years ago
Cc: | added |
---|
comment:2 by , 6 years ago
Milestone: | 18.11 → 18.12 |
---|
by , 6 years ago
Attachment: | 16911-UndoRedo.patch added |
---|
The attached patch seems to solve the problem but if I got that right ensureTreesConsistency() should do that already, so I'll dig into this again.