Modify

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#16907 closed defect (fixed)

Plugin manifest property name mismatch Minimum-Java-Version/Plugin-Minimum-Java-Version

Reported by: allier-osm Owned by: team
Priority: normal Milestone: 18.10
Component: Core Version: latest
Keywords: java11 javafx plugin Cc:

Description (last modified by Don-vip)

Following #16682, it seems there is a mismatch between:

  • the property name "Plugin-Minimum-Java-Version" set in build-commons.xml, target "add-manifest-attribute"
  • the property name "Minimum-Java-Version" read in org.openstreetmap.josm.plugins.PluginInformation.scanManifest()

See the corresponding commits:
[o34604] on 27/08/18 at 13:27 see #josm16682 - new property Plugin-Minimum-Java-Version for openjfx plugin
r14186 on 27/08/18 at 20:12 see #16682 - add new plugin property Minimum-Java-Version

Attachments (0)

Change History (6)

comment:1 Changed 3 weeks ago by Don-vip

Description: modified (diff)

comment:2 Changed 3 weeks ago by Don-vip

Ah, good catch!

comment:3 Changed 3 weeks ago by Don-vip

Keywords: java11 javafx added

comment:4 Changed 3 weeks ago by Don-vip

Component: PluginCore
Keywords: plugin added
Milestone: 18.10

Plugin-Minimum-Java-Version makes more sense.

comment:5 Changed 3 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 14378/josm:

fix #16907 - fix plugin manifest property name mismatch: use Plugin-Minimum-Java-Version

comment:6 Changed 3 weeks ago by allier-osm

Thanks, that was quick :-)

I have updated the developers' guide accordingly:
In https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins:
Plugin-Minimum-Java-Version | optional | Integer minimum version of Java required to use this plugin (since r14186).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.