Modify ↓
#16907 closed defect (fixed)
Plugin manifest property name mismatch Minimum-Java-Version/Plugin-Minimum-Java-Version
| Reported by: | allier-osm | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 18.10 |
| Component: | Core | Version: | latest |
| Keywords: | java11 javafx plugin | Cc: |
Description (last modified by )
Following #16682, it seems there is a mismatch between:
- the property name "Plugin-Minimum-Java-Version" set in build-commons.xml, target "add-manifest-attribute"
- the property name "Minimum-Java-Version" read in org.openstreetmap.josm.plugins.PluginInformation.scanManifest()
See the corresponding commits:
[o34604] on 27/08/18 at 13:27 see #josm16682 - new property Plugin-Minimum-Java-Version for openjfx plugin
r14186 on 27/08/18 at 20:12 see #16682 - add new plugin property Minimum-Java-Version
Attachments (0)
Change History (6)
comment:1 by , 6 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 6 years ago
comment:3 by , 6 years ago
| Keywords: | java11 javafx added |
|---|
comment:4 by , 6 years ago
| Component: | Plugin → Core |
|---|---|
| Keywords: | plugin added |
| Milestone: | → 18.10 |
Plugin-Minimum-Java-Version makes more sense.
comment:6 by , 6 years ago
Thanks, that was quick :-)
I have updated the developers' guide accordingly:
In https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins:
Plugin-Minimum-Java-Version | optional | Integer minimum version of Java required to use this plugin (since r14186).
Note:
See TracTickets
for help on using tickets.
Ah, good catch!