"Click to remove offset" button deletes saved layer offset

[anonymous]

What steps will reproduce the problem?

1. In the "Layers" panel, click on the button to the left of the layer labeled "layer has a user-defined offset (click to remove offset)"

What is the expected result?

Offset of the layer should be reset to 0.00;0.00 (as if no saved offset had been selected), The saved offset should be untouched and remain available for future use.

What happens instead?

The saved offset is permanently changed to 0.00;0.00. User loses the saved offset and has to go through the process of creating a new one again.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-01 23:59:36 +0200 (Mon, 01 Oct 2018)
Revision:14289
Build-Date:2018-10-01 22:08:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14289 en) Linux Ubuntu 18.04.1 LTS
Memory Usage: 377 MB / 2974 MB (116 MB allocated, but free)
Java version: 10.0.2+13-Ubuntu-1ubuntu0.18.04.2, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-10.0.2+13-1ubuntu0.18.04.2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-20ubuntu0.1
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (34506)
+ apache-http (34632)
+ buildings_tools (34572)
+ jna (34633)
+ measurement (34529)
+ openjfx (34625)
+ print (34576)
+ reverter (34552)
+ undelete (34568)
+ utilsplugin2 (34506)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
- https://github.com/GlassOceanos/indoor-JOSM-style/archive/master.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Potlach2_access&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ ${HOME}/Documents/Styles_Sidewalks2.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: Unable to use English input method

[Don-vip]

Closed as duplicate of #12532.
That's the point of removing the offset. Keeping the old offset for each layer would be cumbersome. Instead we can keep a global history, see #12532

[oba510]

Replying to Don-vip:

Closed as duplicate of #12532.
That's the point of removing the offset. Keeping the old offset for each layer would be cumbersome. Instead we can keep a global history, see #12532

It's not clear to me how this is a duplicate of #12532.

The issue here is that when a bookmarked offset is in use, instead of simply removing the offset (as expected) the button unexpectedly alters the saved bookmark as well. It's easy to accidentally click on the button since it's right next to the layer visibility toggle.

Also, because of this, the only way to reset the offset without losing your bookmarks is to create a new bookmarked offset at 0,0, which is a bit of a workaround and not the obvious solution.

(This is probably the same issue as reported in ticket:15711#comment:16 )