#16900 closed enhancement (fixed)
Add undocumented popular tags
Reported by: | Don-vip | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 22.10 |
Component: | Internal preset | Version: | |
Keywords: | unknown_tags ex-longterm | Cc: | Klumbumbus |
Description (last modified by )
From ticket:16793#comment:6 we found out JOSM does not know about many popular tags (but undocumented on OSM wiki).
Below the list we should focus on (removed: tags containing uppercase, numeric, blank and non-latin characters)
age=mature
- 30373age=semi-mature
- 14014age=young
- 10692amenity=mobile_money_agent
- 10274authoritative=yes
- 11423backup_generator=no
- 22718border_type=city
- 17329border_type=county
- 13297border_type=freguesia
- 11111building=kitchen
- 12040building=trullo
- 13504building:part=room
- 10878condition=deficient
- 27972condition=fair
- 74805condition=good
- 65061cosmha=yes
- 45344crossing=zebra
- 524978 (duplicate of crossing_ref=zebra, introduced by iD)dataset=buildings
- 75846designation=public_bridleway
- 29334designation=public_footpath
- 142993detail=track
- 23249driveway=garage
- 14032editor=opengislab 2018
- 11245entrance=unisex
- 10242exit=yes
- 10722flood_prone=no
- 11202flood_prone=yes
- 12800healthcare=doctor
- 14530healthcare=hospital
- 12721healthcare=pharmacy
- 13477highspeed=no
- 11515highspeed=yes
- 53445house=detached
- 15682 (deprecated)house=semi-detached
- 40530 (deprecated)house=terraced
- 18804 (deprecated)importance=national
- 31234importance=regional
- 21733intermittent=no
- 27277 (same as not set, introduced by iD)lamp_type=electric
- 47536lamp_type=electrical
- 10162lamp_type=gaslight
- 16374lcn=yes
- 131945length_unit=km
- 64167light_source=lantern
- 33711maintenance=salting
- 15920meadow=agricultural
- 302836meadow=agriculture
- 13112mechanical=yes
- 13934median=no
- 12002operational_status=open
- 20853operational_status=operational
- 17735operational_status_quality=confirmed
- 15527osm_type=way
- 11874ownership=municipal
- 15910protected=perpetuity
- 22191rcn=yes
- 15760review=no
- 81256service=irrigation
- 10373 (ignored)shoulder=no
- 10443shoulder=yes
- 10914side=right
- 16196sidewalk=none
- 283898 (synonym forsidewalk=no
)site=geodesic
- 72715site=stop_area
- 46740snowplowing=yes
- 37117source_type_imagery=yes
- 34497standing=low
- 47698standing=very_low
- 58857stop=minor
- 11804stream=ephemeral
- 60285stream=fixme
- 33001stream=perennial
- 19451structure_gauge=GC
- 20451todo=continue
- 24120 (better usefixme=*
)trailblazed=yes
- 26452tree_form=natural
- 45535tunnel=no
- 22481 (same as unset)type=turnlanes:turns
- 23348wall=yes
- 50279waterway=artificial
- 16694working=yes
- 29620
Attachments (0)
Change History (38)
comment:2 by , 6 years ago
Description: | modified (diff) |
---|
comment:3 by , 6 years ago
Description: | modified (diff) |
---|
comment:4 by , 5 years ago
comment:5 by , 5 years ago
Description: | modified (diff) |
---|
comment:6 by , 5 years ago
Milestone: | → Longterm |
---|---|
Type: | defect → enhancement |
comment:7 by , 5 years ago
todo=continue
- based on quick look looks like an organic use ( https://taginfo.openstreetmap.org/tags/todo=continue#map )
Maybe turn all todo
into fixme
as long as there is no fixme
tag?
leaf_type=broadl-leaved
- now dropped to below 1000 level - see https://overpass-turbo.eu/s/MiC
dataset=buildings
- badly done import in Washington, see for example https://www.openstreetmap.org/changeset/5155755 (now documented at OSM wiki as a horrible idea)
waterway=artificial
- badly done import, see https://lists.openstreetmap.org/pipermail/tagging/2019-August/047809.html thread (now documented at OSM wiki as a horrible idea)
(if considered as useful I may similarly review more tags)
comment:8 by , 5 years ago
The keys healthcare=*
and healthcare:speciality=*
are now in state "approved" and widely used (>200k times):
https://wiki.openstreetmap.org/wiki/Key:healthcare
The keys amenity=doctors, amenity=dentist, amenity=clinic and amenity=hospital are only in state "de facto".
Would it be time, that the Validator at least stops complaining about "Presets do not contain property key" for healthcare and healthcare:speciality?
I think there are external presets which could be used to integrate into the internal presets of JOSM.
comment:9 by , 5 years ago
More general: there are several keys which are approved, but the validator complains about like Key:cash_withdrawal
which is approved (since 2019-09-19), but JOSM didn't know about.
Is there a possibility to scan the wiki or taginfo for approved keys and compare it with known keys in JOSM?
comment:10 by , 5 years ago
Description: | modified (diff) |
---|
Removed leaf_type=broadl-leaved as per comment:7 and the remaining ones are catched by the "x looks like y" warning.
comment:11 by , 5 years ago
Them maybe removal from list ones caught by valid "X looks like Y" also would be a good idea?
comment:12 by , 5 years ago
Description: | modified (diff) |
---|
comment:13 by , 5 years ago
Description: | modified (diff) |
---|
comment:14 by , 5 years ago
Description: | modified (diff) |
---|
comment:15 by , 5 years ago
Description: | modified (diff) |
---|---|
Keywords: | unknown tags added |
comment:16 by , 5 years ago
Description: | modified (diff) |
---|
follow-up: 20 comment:17 by , 5 years ago
stream=intermittent - 88537
import-induced mistagging - strictly limited area ( https://taginfo.openstreetmap.org/tags/stream=intermittent#map ), appeared in one step - see https://taghistory.raifer.tech/#***/stream/intermittent
Should be intermittent=yes
and mostly is https://taginfo.openstreetmap.org/tags/stream=intermittent#combinations
I will try to deimport this.
follow-up: 21 comment:18 by , 5 years ago
amenity=private_toilet
should disappear soon, nearly all of them were added in an undiscussed import that I just reverted
See https://www.openstreetmap.org/changeset/58762350 https://www.openstreetmap.org/changeset/58760097
comment:19 by , 5 years ago
Description: | modified (diff) |
---|
comment:20 by , 5 years ago
Replying to mkoniecz:
stream=intermittent - 88537
import-induced mistagging - strictly limited area ( https://taginfo.openstreetmap.org/tags/stream=intermittent#map ), appeared in one step - see https://taghistory.raifer.tech/#***/stream/intermittent
Should be
intermittent=yes
and mostly is https://taginfo.openstreetmap.org/tags/stream=intermittent#combinations
I will try to deimport this.
I added a warning for now, see #19396.
comment:21 by , 5 years ago
Replying to mkoniecz:
amenity=private_toilet
should disappear soon, nearly all of them were added in an undiscussed import that I just reverted
See https://www.openstreetmap.org/changeset/58762350 https://www.openstreetmap.org/changeset/58760097
There is a new spot, but "only" 282 objects so far: https://overpass-turbo.eu/?w=%22amenity%22%3D%22private_toilet%22+global&R
comment:22 by , 5 years ago
Description: | modified (diff) |
---|
comment:23 by , 5 years ago
Description: | modified (diff) |
---|
Updated the access tags included in r16742.
comment:24 by , 4 years ago
Description: | modified (diff) |
---|
comment:25 by , 4 years ago
Actually
healthcare=doctor
is approved and has now more than 50000 uses.
healthcare=hospital
is approved and has now more than 50000 uses.
healthcare=pharmacy
has now more than 100000 uses. The wiki suggest to add healthcare=pharmacy
to existing amenity=pharmacy
objects.
comment:26 by , 4 years ago
"The wiki suggest to add healthcare=pharmacy to existing amenity=pharmacy objects."
On which page?
https://wiki.openstreetmap.org/wiki/Tag:healthcare%3Dpharmacy and https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dpharmacy does not
comment:27 by , 4 years ago
https://wiki.openstreetmap.org/wiki/Tag:healthcare%3Dpharmacy:
Tag history
Multiple
healthcare=*
tags were introduced by healthcare proposal. This tag duplicatingamenity=pharmacy
was not introduced by this proposal. Author of the healthcare proposal wanted to deprecateamenity=pharmacy
and replace it withshop=pharmacy
, but due to strong opposition to deprecatingamenity=pharmacy
this was abandoned.
This tag started to be used later anyway, with intention to
- Add
healthcare=pharmacy
to existingamenity=pharmacy
objects- Add support in at least prominent data consumers for also
healthcare=pharmacy
in addition to supportingamenity=pharmacy
- Remove support for
amenity=pharmacy
in data consumers and remove this tag from pharmaciesThere is opposition to this potential deprecation of widely used tag
amenity=pharmacy
. There is some support but it is often motivated by "this is part of the accepted proposal".
comment:28 by , 2 years ago
How to deal with this ticket?
We have a test for such tags: org.openstreetmap.josm.data.osm.TaginfoTestIT.testCheckPopularTags()
And we have separate tickets solving the cases reported by this test like #14347, #20447, #21396
This is an endless job, but does it make sense to keep this ticket open? I think all mentioned tags in this ticket are handled or not longer a problem.
comment:29 by , 2 years ago
I think that in general idea is to create listing of what is not handled by JOSM and either start supporting tags/retag tags/mark them as ignored and then close ticket and open a new one with fresh listing.
comment:30 by , 2 years ago
So I guess that I would run this test, confirm that nothing is from this ticket (or is from this ticket but there is no useful discussion) and close this one and open new.
comment:31 by , 2 years ago
It looks like the current missing tags are:
- building=sports_centre - 10049
- dual_carriageway=yes - 11057
- location=surface - 122947
- man_made=lamp - 11708
comment:32 by , 2 years ago
As I said, this is an endless job. But this ticket deals with a specific list of tags (see description). Are these tags solved?
There are already new tickets for new results of the test: #20447, #21396
And there are actually new missing tags as taylor smock said.
But we have lots of endless taks, where we don't create longterm tickets like changing TopLevelDomains, new Ubuntu versions, ....
My question was: does it make sense to keep THIS ticket open? It is about an old list of problems.
Wouldn't it make more sense to open a new ticket, when there are new missing tags instead of using this old ticket, which was not done for several years now!
comment:33 by , 2 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Yeah, this one is fixed as far as I can see.
comment:34 by , 2 years ago
(if this one is intended to be kept open forever, then description ideally would be changed with specific tag list shunted of to a separate issue)
(I have not opened a new one for https://josm.openstreetmap.de/ticket/16900#comment:31 list)
comment:35 by , 2 years ago
Keywords: | ex-longterm added |
---|---|
Milestone: | Longterm |
comment:36 by , 2 years ago
Keywords: | unknown_tags added; unknown tags removed |
---|
comment:37 by , 2 years ago
I'm kind of planning on trying to keep on top of that for the foreseeable future (I get an RSS feed notification every 8 hours or so while that test is failing). I just don't want to add stuff right before I do a release (which is what I'm doing today). So hopefully we never have a big long list of tags to add in the future.
I just won't be adding new presets (most new top-level objects are going to be ignored until someone comes up with a good icon for it).
comment:38 by , 2 years ago
Milestone: | → 22.10 |
---|
building=collapsed - HOT induced mistagging, it is not a building purpose (and it is disputable whatever collapsed remains of a building are a building)
building=damaged - HOT induced mistagging, it is not a building purpose
condition=deficient/fair/good - highly suspicious subjective tagging
flood_prone=yes/no - is it really verifiable?
tunnel=no - sounds like iD induced pointless tagging
healthcare=doctor/hospital/pharmacy - looks potentially reasonable, but it duplicates existing tags (sounds like someone disliking existing tagging scheme and creating duplicate with hope that original will soon disappear)