Crossing highway/railway - exclude railway=construction + construction=tram and railway=disused + disused=tram (railway=tram is now excluded) [patch]

[mkoniecz]

What steps will reproduce the problem?

1. Wait for long-term tram reconstruction
2. Wait for someone to tag it as railway=construction + construction=tram
3. Run JOSM validator

What is the expected result?

No additional complaints.

What happens instead?

construction=tram is not recognised as tram for purposes of crossing rule

Please provide any additional information below. Attach a screenshot if possible.

​https://www.openstreetmap.org/way/234565950#map=15/50.0704/19.9175

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-23 01:34:26 +0200 (Tue, 23 Oct 2018)
Build-Date:2018-10-23 01:33:02
Revision:14358
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14358 en) Linux Ubuntu 16.04.5 LTS
Memory Usage: 399 MB / 869 MB (140 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34535)
+ buildings_tools (34572)
+ continuosDownload (82)
+ imagery_offset_db (34641)
+ measurement (34529)
+ reverter (34552)
+ todo (30306)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[Klumbumbus]

I don't get validator warnings for the linked way.
You mean you want to see warnings about missing railway=crossing or railway=level_crossing tags on nodes?

[mkoniecz]

Weird, I will test with latest JOSM (14366).

I downloaded ​https://www.openstreetmap.org/way/234565950#map=19/50.07570/19.90672 and validated with way selected. No reports found.

I unselected it and rerun validator again. Now validator started to complain.

You mean you want to see warnings about missing railway=crossing or railway=level_crossing tags on nodes?

I want, but it is unrelated.

[Klumbumbus]

Replying to mkoniecz:

it is unrelated.

Then I don't understand the aim of this ticket.

[mkoniecz]

railway=construction, construction=tram is causing complaints

the same geometry with railway=tram is not causing complaints

I think that either both should complain on crossing with road or neither

see attachment for a simpler test

[Klumbumbus]

both should not warn as tram ways often run on top of highway ways.
Untested, someone please check if this is the correct fix:

CrossingWays.java

@@ -329 +329 @@
     }
 
     static boolean isSubwayOrTramOrRazed(OsmPrimitive w) {
-        return w.hasTag(RAILWAY, "subway", "tram", "razed");
+        return w.hasTag(RAILWAY, "subway", "tram", "razed") || w.hasTag(RAILWAY, "construction") && w.hasTag("construction", "tram");
     }
 
     static boolean isProposedOrAbandoned(OsmPrimitive w) {

[mkoniecz]

There is also railway=disused, disused=tram with the same issue for example at ​https://www.openstreetmap.org/way/233730605

[Don-vip]

In 14452/josm:

fix #16889 - better handling of trams in CrossingWays test