Modify

Opened 7 months ago

Closed 7 months ago

#16885 closed enhancement (fixed)

[PATCH] Small update for toilets preset

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.10
Component: Internal preset Version:
Keywords: drinking water toilets Cc:

Description

drinking_water=seasonal doesn't seem to make sense here:

  • data/defaultpresets.xml

    diff --git a/data/defaultpresets.xml b/data/defaultpresets.xml
    index 1f83f2641..47f738068 100644
    a b  
    59865986                    <check key="unisex" text="Unisex" text_context="restroom" />
    59875987                </checkgroup>
    59885988                <combo key="toilets:disposal" text="Type" values="flush,pitlatrine,chemical,bucket" />
    5989                 <combo key="drinking_water" text="Drinking Water" values="yes,no,seasonal" />
     5989                <combo key="drinking_water" text="Drinking Water" values="yes,no" />
    59905990                <text key="description" text="Description" />
    59915991                <reference ref="fee" />
    59925992                <text key="operator" text="Operator" />

Attachments (0)

Change History (6)

comment:1 Changed 7 months ago by Don-vip

Keywords: drinking water toilets added
Milestone: 18.10

comment:2 Changed 7 months ago by stoecker

It should no longer be a combo then...

comment:3 Changed 7 months ago by naoliv

Just a moment and I will fix this :-)

comment:4 Changed 7 months ago by naoliv

I moved it down as it seems to be the least ugly solution, I think:

https://i.imgur.com/OHfZrbF.png

  • data/defaultpresets.xml

    diff --git a/data/defaultpresets.xml b/data/defaultpresets.xml
    index 1f83f2641..1aaf3d3bd 100644
    a b  
    59865986                    <check key="unisex" text="Unisex" text_context="restroom" />
    59875987                </checkgroup>
    59885988                <combo key="toilets:disposal" text="Type" values="flush,pitlatrine,chemical,bucket" />
    5989                 <combo key="drinking_water" text="Drinking Water" values="yes,no,seasonal" />
    59905989                <text key="description" text="Description" />
    59915990                <reference ref="fee" />
    59925991                <text key="operator" text="Operator" />
    59935992                <combo key="toilets:position" text="Usage Position" values="seated,seated;urinal,squat,urinal" />
    59945993                <combo key="diaper" text="Diaper" values="yes,no,room,1,2,3,4,5" text_context="toilets" />
    59955994                <reference ref="wheelchair" />
     5995                <check key="drinking_water" text="Drinking Water" />
    59965996            </optional>
    59975997        </item> <!-- Toilets/Restrooms -->
    59985998        <item name="Shower" icon="presets/service/shower.svg" type="node,closedway" preset_name_label="true">

comment:5 Changed 7 months ago by naoliv

BTW, shouldn't everything be optional in the preset, including access?

comment:6 Changed 7 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14365/josm:

fix #16885 - remove drinking_water=seasonal from toilet preset (patch by naoliv)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.