Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#16615 closed defect (fixed)

Not all dialog made empty when deleting data layer

Reported by: DTeelde@… Owned by: Don-vip
Priority: major Milestone: 18.08
Component: Core Version: latest
Keywords: template_report regression selection performance memory Cc: floscher

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

  1. Download some data from OSM
  2. Open the dialog voor Tags and Relations
  3. Select an node or way with tags; the tags will be shown in the dialog
  4. Delete the data layer

What is the expected result?

The lists within the dialogs should be cleared

What happens instead?

The tags of the previous node/way are kept in the list. Also the downloaded relations still exists in the list of Relations.

Choosing the drown down menu item 'Download (incomplete) members' or a relation will cause such an error.

Please provide any additional information below. Attach a screenshot if possible.

Print screen of the situation

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (19) of main
java.lang.NullPointerException
	at java.util.Objects.requireNonNull(Unknown Source)
	at org.openstreetmap.josm.gui.dialogs.relation.DownloadRelationMemberTask.<init>(DownloadRelationMemberTask.java:73)
	at org.openstreetmap.josm.actions.relation.DownloadSelectedIncompleteMembersAction.actionPerformed(DownloadSelectedIncompleteMembersAction.java:57)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.AbstractButton.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (1)

JOSM_2018-08-14 19_07_31-Window.jpg (81.3 KB) - added by DTeelde@… 6 months ago.
Print screen of the situation

Download all attachments as: .zip

Change History (9)

Changed 6 months ago by DTeelde@…

Print screen of the situation

comment:1 Changed 6 months ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 6 months ago by Don-vip

Keywords: regression added
Milestone: 18.08

comment:3 Changed 6 months ago by Don-vip

Regression somewhere between r13878 (works fine) and r13996 (does not work).

EDIT: regression of r13925 + r13926: r13924 works. r13926 does not.

Last edited 6 months ago by Don-vip (previous) (diff)

comment:4 Changed 6 months ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:5 Changed 6 months ago by Don-vip

Keywords: selection added

comment:6 Changed 6 months ago by Don-vip

Keywords: performance memory added
Priority: normalmajor

comment:7 Changed 6 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 14156/josm:

fix #16615 - make sure dataset can be garbage collected after removal (regression from r13926)

comment:8 Changed 6 months ago by Don-vip

Cc: floscher added

@Florian: if you make this test with Mapillary plugin installed you will notice the field org.openstreetmap.josm.plugins.mapillary.gui.imageinfo.AddTagToPrimitiveAction#target retain the value of the selected OSM primitive, thus forbidding the garbage collector to free memory for the entire dataset. Can you please fix it?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.