Changeset 13878 in josm

Timestamp:

2018-05-31T00:51:20+02:00 (7 years ago)

Author:

wiktorn

Message:

Fix identifying if getMapUrl contains query part.

See: #16330

Location:

trunk

Files:

• src/org/openstreetmap/josm/io/imagery/WMSImagery.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/io/imagery/WMSImageryTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/imagery/WMSImagery.java

@@ -432 +432 @@
                         // TODO should we handle also POST?
                         if ("GET".equalsIgnoreCase(mode) && getMapUrl != null && !"".equals(getMapUrl)) {
-                            if (getMapUrl.endsWith("?")) {
-                                this.getMapUrl = getMapUrl;
-                            } else {
-                                this.getMapUrl = getMapUrl + "?";
+                            try {
+                                String query = (new URL(getMapUrl)).getQuery();
+                                if (query == null || query.isEmpty()) {
+                                    this.getMapUrl = getMapUrl + "?";
+                                } else {
+                                    this.getMapUrl = getMapUrl;
+                                }
+                            } catch (MalformedURLException e) {
+                                throw new XMLStreamException(e);
                             }
                         }

trunk/test/unit/org/openstreetmap/josm/io/imagery/WMSImageryTest.java

@@ -91 +91 @@
                 );
         WMSImagery wms = new WMSImagery(tileServer.url("any"));
-        assertEquals("http://wms.hgis.cartomatic.pl/topo/3857/m25k", wms.buildRootUrl());
+        assertEquals("http://wms.hgis.cartomatic.pl/topo/3857/m25k?", wms.buildRootUrl());
         assertEquals("wms.hgis.cartomatic.pl", wms.getLayers().get(0).getName());
-        assertEquals("http://wms.hgis.cartomatic.pl/topo/3857/m25kFORMAT=image/png&TRANSPARENT=TRUE&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&"
+        assertEquals("http://wms.hgis.cartomatic.pl/topo/3857/m25k?FORMAT=image/png&TRANSPARENT=TRUE&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&"
                 + "LAYERS=wms.hgis.cartomatic.pl&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}",
                 wms.buildGetMapUrl(wms.getLayers(), (List<String>) null, true));