Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#16441 closed defect (wontfix)

JOSM produces a validation warning after encouraging 'reverse way' function

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Select a way (like a highway) with oneway=yes.
  2. Use 'reverse way' to reverse the way.
  3. The function will suggest that you change the value of oneway=yes to oneway=-1.
  4. Perform a validation.
  5. You are now issued a validation warning for doing what JOSM asked you to do.

What is the expected result?

Reversing a way with oneway=yes shouldn't suggest a change in that key's value. It probably SHOULD warn asking a user to verify the one way way's direction.

What happens instead?

See attached: contradictory instructions.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-06-30 01:04:46 +0200 (Sat, 30 Jun 2018)
Revision:13985
Build-Date:2018-06-30 01:32:07
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (13985 en) Mac OS X 10.13.5
OS Build number: Mac OS X 10.13.5 (17F77)
Memory Usage: 2077 MB / 5120 MB (797 MB allocated, but free)
Java version: 10.0.1+10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69680128 1440x900
Maximum Screen Size: 1440x900
Dataset consistency test: No problems found

Plugins:
+ ImportImagePlugin (34219)
+ apache-commons (34109)
+ ejml (34126)
+ geotools (34125)
+ jts (34038)
+ log4j (34038)
+ opendata (34335)
+ pbf (34296)
+ utilsplugin2 (34286)
+ wikipedia (v1.0.1)

Last errors/warnings:
- W: Update plugins - org.openstreetmap.josm.plugins.PluginHandler$UpdatePluginsMessagePanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (2)

Screenshot 2018-06-29 23.11.39.png (33.0 KB ) - added by anonymous 8 years ago.
Reverse way dialog
Screenshot 2018-06-29 23.12.14.png (13.2 KB ) - added by anonymous 8 years ago.
Warning produced for...doing what you were asked to do.

Download all attachments as: .zip

Change History (4)

by anonymous, 8 years ago

Reverse way dialog

by anonymous, 8 years ago

Warning produced for...doing what you were asked to do.

comment:1 by Don-vip, 8 years ago

Resolution: wontfix
Status: newclosed

The idea of this dialog is to choose what action needs to be done, not to apply blindly the default one. If we knew for sure what needs to be done there would be no dialog.

comment:2 by anonymous, 8 years ago

I get it, this is 'wontfix'...

Just as a closing comment, I guess -- if -1 is 'not recommended' in the first place (this is what the validation warning says after all), why have a dialog that, _by default_ (when oneway=yes is present on the way), doesn't actually encourage changing the direction of the way, but instead adding 'oneway=-1'?

iD just reverses the direction of the way, full stop. I guess perhaps I don't understand what this is trying to guard against in the first place. Anyway, appreciate the response just the same.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.