Modify

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#1633 closed enhancement (fixed)

[Patch] Unglue does not unglue single node

Reported by: dieterdreist Owned by: framm
Priority: trivial Milestone:
Component: Core Version:
Keywords: unglue node Cc:

Description

The unglue function does not allow to unglue a single node. This should be possible to separate erratously connected ways to single node pois. The example I can give here was a drinking_water place that was connected to a subway, I know the situation there, the drinking_water is NOT in the subway).
The unglue plugin/function gave me an error (must select two *ways*).

Attachments (1)

Add Unglue Node.patch (6.7 KB ) - added by xeen 16 years ago.
This differs from the rest of unglue in that it takes the mouse position into account. This should be no problem though for a single node and also solves the selection-order problem that always seems to select the old node

Download all attachments as: .zip

Change History (11)

comment:1 by stoecker, 16 years ago

Resolution: wontfix
Status: newclosed

Use Copy and Paste to separate a POI from a way.

comment:2 by dieterdreist, 16 years ago

Priority: majorminor
Resolution: wontfix
Status: closedreopened
Type: defectenhancement

OK, I try it again. To maintain consistency/improve usability I think this could be an enhancement.

comment:3 by anonymous, 16 years ago

Resolution: worksforme
Status: reopenedclosed

You don't unglue. You make a new node. So the answer is still the same. Use Copy and Paste.

in reply to:  3 ; comment:4 by dieterdreist, 16 years ago

Resolution: worksforme
Status: closedreopened

Replying to anonymous:

You don't unglue. You make a new node. So the answer is still the same. Use Copy and Paste.

you do copy, paste and the select the node and delete all key/values you don't want there. This can be really a lot. If someone attached all housenumbers to the street, incl. postcode, address, country,... you will be quite busy for a single road, for a whole quarter you might even decide not to do it at all.

As this is marked as enhancement and not as bug I will reopen it.

comment:5 by anonymous, 16 years ago

Why is deleting the keys complicated? JOSM has been improved a lot in this respect. Press delete 10 times and 10 lines have been deleted. The old selection-delete-select-delete marathon is no longer necessary.

in reply to:  4 comment:6 by xeen, 16 years ago

Priority: minortrivial

How should a single node be unglued? There is really _no_ way for current computers to know what should be kept on the original node and what should be copied to the new one.

So, all it could do was duplicate the node and delete all tags from the old one. Is this what you are asking for? I do this from times to times with bus stops that are tagged as a single node on a street with CTRL+D, CTRL+D and deleting all tags with ALT+Q (*) on the original node.

It's not an option that's needed every day and there's an easy workaround if you want to >>unglue<< a whole street:

  • select nodes
  • add tag 123=123
  • CTRL+D and move the nodes to where you want them
  • remove the 123=123 tag from the duplicated nodes
  • CTRL+F, search for "123:123"
  • delete now selected nodes

Also, how to decide what to do when there're two ways joined you want to unglue when their connecting has additional tags? The only sane "UI option" would be to unglue the ways and put the tags into a separate node. Re-connecting the two ways probably costs you as much time as just duplicating the node.

*: I have a work in progress patch that will make this even easier.

comment:7 by stoecker, 16 years ago

Status: reopenednew

by xeen, 16 years ago

Attachment: Add Unglue Node.patch added

This differs from the rest of unglue in that it takes the mouse position into account. This should be no problem though for a single node and also solves the selection-order problem that always seems to select the old node

comment:8 by xeen, 16 years ago

Summary: Unglue does not unglue single node[Patch] Unglue does not unglue single node

Just for you dieterdreist :)

comment:9 by stoecker, 16 years ago

Resolution: fixed
Status: newclosed

Fixed in r1429.

in reply to:  8 comment:10 by dieterdreist, 16 years ago

Replying to xeen:

Just for you dieterdreist :)

thanks a lot! I will test it now. -- yeah, tried it and it works like a charm.

dD

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.