Modify

Opened 8 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#16320 closed enhancement (fixed)

increase contrast of delete icon

Reported by: aceman Owned by: team
Priority: normal Milestone: 18.06
Component: Core Version: latest
Keywords: contrast icon Cc:

Description

In the relation editor dialog the delete icons (all of them: delete relation, delete tag, delete relation member) have changed their appearance recently. They are grey trashcan, but there is no difference when the button is enabled and when disabled. The icon looks like permanently disabled, even when it isn't.

This could be related to some GTK changes in Linux. I'm on GTK 3.22.30

Attachments (3)

bug-JOSM-relation-delete.png (43.1 KB) - added by aceman 8 weeks ago.
screenshot
bug-JOSM-relation-delete-disabled.png (38.5 KB) - added by aceman 8 weeks ago.
screenshot of disabled icon
delete.svg (26.6 KB) - added by Klumbumbus 8 weeks ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 8 weeks ago by Don-vip

Owner: changed from team to aceman
Status: newneedinfo

Changed in r13837. Can you please attach a screenshot? The difference is clear on Windows.

Changed 8 weeks ago by aceman

screenshot

comment:2 Changed 8 weeks ago by aceman

Added the screenshot. It shows a state where all the 3 icons are enabled (mousehover on them shows tooltips and the button outline) and can be clicked on. But the grey appearance looks like they are disabled. There is no color difference between enabled and disabled state. For other icons, the difference is very visible.

comment:3 Changed 8 weeks ago by Don-vip

It appears very clear the buttons are enabled. Can you please post also a screenshot where they're disabled so I can compare?

comment:4 Changed 8 weeks ago by aceman

The other buttons are fine. I talk only about the "delete" (trash can) icon. I say that its enabled appearance is so gray as it almost looks as if disabled. Screenshot incoming.

Changed 8 weeks ago by aceman

screenshot of disabled icon

comment:5 Changed 8 weeks ago by aceman

I mean if the trash can icon could get any more colors or contrast so that it can immediately be seen if it is enabled or not.

comment:6 Changed 8 weeks ago by Don-vip

Keywords: contrast icon added
Summary: delete icon in relation editor looks permanently disabled on Linuxincrease contrast of delete icon
Type: defectenhancement

OK. For me this is not a problem, I can easily spot the difference. Patched version of svg icon is welcome.

comment:7 Changed 8 weeks ago by Don-vip

Owner: changed from aceman to team
Status: needinfonew

comment:8 Changed 8 weeks ago by Klumbumbus

The old icons was a bit darker:

source:trunk/images/dialogs/delete.png@7668source:trunk/images/dialogs/delete.svg@13837

Changed 8 weeks ago by Klumbumbus

Attachment: delete.svg added

comment:9 Changed 8 weeks ago by Klumbumbus

adjusted:


Last edited 8 weeks ago by Klumbumbus (previous) (diff)

comment:10 Changed 8 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13841/josm:

fix #16320 - increase contrast of delete icon

comment:11 Changed 8 weeks ago by Klumbumbus

Milestone: 18.05

comment:12 Changed 8 weeks ago by Klumbumbus

Milestone: 18.0518.06
Resolution: fixed
Status: closedreopened

Apparently the icon is not displayed correctly within JOSM.

comment:13 Changed 8 weeks ago by Klumbumbus

It seems this svg code is not supported by JOSM or removed by the svg optimizer:

    <filter
       style="color-interpolation-filters:sRGB;"
       inkscape:label="Lightness-Contrast"
       id="filter4720">
      <feColorMatrix
         values="1.365 0 0 -0.314102 -0.1825 0 1.365 0 -0.314102 -0.1825 0 0 1.365 -0.314102 -0.1825 0 0 0 1 0"
         id="feColorMatrix4718"
         result="fbSourceGraphic" />
      <feColorMatrix
         result="fbSourceGraphicAlpha"
         in="fbSourceGraphic"
         values="0 0 0 -1 0 0 0 0 -1 0 0 0 0 -1 0 0 0 0 1 0"
         id="feColorMatrix924" />
      <feColorMatrix
         id="feColorMatrix926"
         values="1 0 0 0.03 -0 0 1 0 0.03 -0 0 0 1 0.03 -0 0 0 0 1 0"
         in="fbSourceGraphic" />
    </filter>
    <filter
       style="color-interpolation-filters:sRGB;"
       inkscape:label="Lightness-Contrast"
       id="filter4724">
      <feColorMatrix
         values="1.365 0 0 -0.314102 -0.1825 0 1.365 0 -0.314102 -0.1825 0 0 1.365 -0.314102 -0.1825 0 0 0 1 0"
         id="feColorMatrix4722"
         result="fbSourceGraphic" />
      <feColorMatrix
         result="fbSourceGraphicAlpha"
         in="fbSourceGraphic"
         values="0 0 0 -1 0 0 0 0 -1 0 0 0 0 -1 0 0 0 0 1 0"
         id="feColorMatrix928" />
      <feColorMatrix
         id="feColorMatrix930"
         values="1 0 0 0.03 -0 0 1 0 0.03 -0 0 0 1 0.03 -0 0 0 0 1 0"
         in="fbSourceGraphic" />
    </filter>
Last edited 8 weeks ago by Klumbumbus (previous) (diff)

comment:14 Changed 7 weeks ago by Don-vip

svgSalamander does not support feColorMatrix it seems.

comment:15 Changed 6 weeks ago by Don-vip

I won't have time to dig into this problem, and the author does not really maintain the library... Can you change the colors without filters?

comment:16 Changed 6 weeks ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 13898/josm:

fix #16320 - increase contrast of delete icon without using filters

comment:17 Changed 6 weeks ago by Klumbumbus

In 13899/josm:

see #16320 - forgot svg mime type

comment:18 Changed 6 weeks ago by Klumbumbus

comparison
old png -> until now -> from now on

source:trunk/images/dialogs/delete.png@7668source:trunk/images/dialogs/delete.svg@13837source:trunk/images/dialogs/delete.svg@13899

comment:19 Changed 6 weeks ago by aceman

Thanks, any darker shade is better.

comment:20 Changed 6 weeks ago by Klumbumbus

In 13900/josm:

fix #16367, see #16320 - fix svg code

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.