increase contrast of delete icon

[aceman]

In the relation editor dialog the delete icons (all of them: delete relation, delete tag, delete relation member) have changed their appearance recently. They are grey trashcan, but there is no difference when the button is enabled and when disabled. The icon looks like permanently disabled, even when it isn't.

This could be related to some GTK changes in Linux. I'm on GTK 3.22.30

[Don-vip]

Changed in r13837. Can you please attach a screenshot? The difference is clear on Windows.

[aceman]

screenshot

[aceman]

Added the screenshot. It shows a state where all the 3 icons are enabled (mousehover on them shows tooltips and the button outline) and can be clicked on. But the grey appearance looks like they are disabled. There is no color difference between enabled and disabled state. For other icons, the difference is very visible.

[Don-vip]

It appears very clear the buttons are enabled. Can you please post also a screenshot where they're disabled so I can compare?

[aceman]

The other buttons are fine. I talk only about the "delete" (trash can) icon. I say that its enabled appearance is so gray as it almost looks as if disabled. Screenshot incoming.

[aceman]

screenshot of disabled icon

[aceman]

I mean if the trash can icon could get any more colors or contrast so that it can immediately be seen if it is enabled or not.

[Don-vip]

OK. For me this is not a problem, I can easily spot the difference. Patched version of svg icon is welcome.

[Klumbumbus]

The old icons was a bit darker:

[Klumbumbus]

adjusted:

[Klumbumbus]

In 13841/josm:

fix #16320 - increase contrast of delete icon

[Klumbumbus]

Apparently the icon is not displayed correctly within JOSM.

[Klumbumbus]

It seems this svg code is not supported by JOSM or removed by the svg optimizer:

    <filter
       style="color-interpolation-filters:sRGB;"
       inkscape:label="Lightness-Contrast"
       id="filter4720">
      <feColorMatrix
         values="1.365 0 0 -0.314102 -0.1825 0 1.365 0 -0.314102 -0.1825 0 0 1.365 -0.314102 -0.1825 0 0 0 1 0"
         id="feColorMatrix4718"
         result="fbSourceGraphic" />
      <feColorMatrix
         result="fbSourceGraphicAlpha"
         in="fbSourceGraphic"
         values="0 0 0 -1 0 0 0 0 -1 0 0 0 0 -1 0 0 0 0 1 0"
         id="feColorMatrix924" />
      <feColorMatrix
         id="feColorMatrix926"
         values="1 0 0 0.03 -0 0 1 0 0.03 -0 0 0 1 0.03 -0 0 0 0 1 0"
         in="fbSourceGraphic" />
    </filter>
    <filter
       style="color-interpolation-filters:sRGB;"
       inkscape:label="Lightness-Contrast"
       id="filter4724">
      <feColorMatrix
         values="1.365 0 0 -0.314102 -0.1825 0 1.365 0 -0.314102 -0.1825 0 0 1.365 -0.314102 -0.1825 0 0 0 1 0"
         id="feColorMatrix4722"
         result="fbSourceGraphic" />
      <feColorMatrix
         result="fbSourceGraphicAlpha"
         in="fbSourceGraphic"
         values="0 0 0 -1 0 0 0 0 -1 0 0 0 0 -1 0 0 0 0 1 0"
         id="feColorMatrix928" />
      <feColorMatrix
         id="feColorMatrix930"
         values="1 0 0 0.03 -0 0 1 0 0.03 -0 0 0 1 0.03 -0 0 0 0 1 0"
         in="fbSourceGraphic" />
    </filter>

[Don-vip]

​svgSalamander does not support ​feColorMatrix it seems.

[Don-vip]

I won't have time to dig into this problem, and the author does not really maintain the library... Can you change the colors without filters?

[Klumbumbus]

In 13898/josm:

fix #16320 - increase contrast of delete icon without using filters

[Klumbumbus]

In 13899/josm:

see #16320 - forgot svg mime type

[Klumbumbus]

comparison
old png -> until now -> from now on

[aceman]

Thanks, any darker shade is better.

[Klumbumbus]

In 13900/josm:

fix #16367, see #16320 - fix svg code