Modify

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#16310 closed enhancement (fixed)

[PATCH] check for duplicate addresses

Reported by: Luzandro Owned by: team
Priority: normal Milestone: 18.06
Component: Core validator Version:
Keywords: address Cc:

Description

I've updated the address validator test, so that it checks for duplicate addresses that use addr:street/addr:place (the old test only checks associatedStreet relations).

Some considerations I've made:

  • POIs are ignored
  • units/flats are considered
  • there is a small amount of tolerance for what is seen as duplicate. For one whitespaces and dashes in street names are ignored, so that "Mozart-Gasse", "Mozart Gasse" and "Mozartgasse" are all seen as equal. And if at least one of the compared objects doesn't have addr:city and/or addr:postcode specified, distance is taken into account to decide if a warning should be generated and with what severity.

Attachments (1)

Addresses.java.patch (9.2 KB) - added by Luzandro 6 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 months ago by Don-vip

Keywords: address added
Milestone: 18.06

Changed 6 months ago by Luzandro

Attachment: Addresses.java.patch added

comment:2 Changed 5 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13968/josm:

fix #16310 - check for duplicate addresses (patch by Luzandro, modified)

comment:3 Changed 5 months ago by Don-vip

Great patch, thanks a lot! Sorry for the delay to apply it.

comment:4 Changed 5 months ago by Don-vip

In 13970/josm:

see #16310 - fix PMD warnings

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.