Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16295 closed enhancement (fixed)

New plugin: Gridify

Reported by: JeroenHoek Owned by: Jeroen Hoek
Priority: normal Milestone:
Component: Plugin Gridify Version:
Keywords: Cc:

Description

Gridify is a plugin that can split a way consisting of four nodes up into a grid of blocks. It is particularly useful for amenity=parking_space, but I suspect it may have other uses.

I have written about this plugin here (screenshots included):

https://forum.openstreetmap.org/viewtopic.php?id=62334

The plugin builds cleanly, and generates no checkstyle errors. I have translated the English text into the languages I speak: Dutch, German, and Japanese.

I have published the code on GitHub under the GPLv3 here:

https://github.com/jdhoek/josm-gridify

I didn't commit any generated artefacts such as class and lang files. I've ran ../../i18n/i18n.pl --basedir=data --potfile=en.pot po/*.po to generate the lang files, and ant dist successfully packages the plugin. All languages appear to work in JOSM.

Will this suffice to have the plugin reviewed and if found acceptable included in JOSM?

Attachments (0)

Change History (11)

in reply to:  description comment:1 by Don-vip, 6 years ago

Replying to mail@…:

Gridify is a plugin that can split a way consisting of four nodes up into a grid of blocks.

Sounds a lot like osmwiki:JOSM/Plugins/Terracer no?

comment:2 by Klumbumbus, 6 years ago

Terracer can only split one row and only along the longer side afaik.

comment:3 by stoecker, 6 years ago

Will this suffice to have the plugin reviewed and if found acceptable included in JOSM?

You simply need to add a link to the Plugin.jar to PluginsSource page.

If you want get rid of the "external" warning and take part in automatic translation, you must transfer the source to "JOSM/" project of GitHub, so that JOSM developers can handle necessary updates and fixes when you aren't available anymore (preferred is that the original author remains available).

comment:4 by anonymous, 6 years ago

Terracer is a tool that specifically targets terraced housing, including details such as house address numbers, and is limited to rows. This plugin is a generic grid splitting tool that does both rows and columns. There is some overlap, but the goals of the plugins are different.

comment:5 by anonymous, 6 years ago

I would like to have the plugin included in the JOSM project to benefit from the combined translation effort. How do I proceed? Will one of the maintainers fork my repository or do I become a member of the JOSM team on GitHub?

comment:6 by Jeroen Hoek, 6 years ago

(Preceding two comments were sent by me.)

comment:7 by Don-vip, 6 years ago

I've invited you to the JOSM organization. Best way is to transfer the repo to the organization (you will remain admin).

comment:8 by anonymous, 6 years ago

Thanks. I've transferred the repository to JOSM.

comment:9 by Klumbumbus, 6 years ago

Component: PluginPlugin Gridify
Owner: changed from team to Jeroen Hoek

The Plugin was added to PluginsSource. Can the ticket be closed or is there something still to do?

comment:10 by anonymous, 6 years ago

Resolution: fixed
Status: newclosed

comment:11 by Jeroen Hoek, 6 years ago

I tested it this afternoon. The plugin is now available in JOSM.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jeroen Hoek.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.