Modify

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#16219 closed defect (fixed)

Imagery projection problem - WMS endpoint

Reported by: nkamapper Owned by: team
Priority: normal Milestone: 18.04
Component: Core imagery Version:
Keywords: template_report norway projection Cc:

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

With the Mercator projection, zoom over the south part of Norway and select the "Kartverket Accessibility" imagery (wms_endpoint), then select any map layer.

What is the expected result?

The chosen WMS map layer should be rendered.

What happens instead?

Projection EPSG:25835 is chosen by JOSM, which only works in the northern part of the country.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-03-26 22:16:39 +0200 (Mon, 26 Mar 2018)
Build-Date:2018-03-26 20:45:23
Revision:13576
Redirecting:to URL 'https://josm.openstreetmap.de/svn/trunk':
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13576 nb) Mac OS X 10.13.4
OS Build number: Mac OS X 10.13.4 (17E199)
Memory Usage: 2131 MB / 3641 MB (879 MB allocated, but free)
Java version: 1.8.0_161-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 722476178 3008x1692
Maximum Screen Size: 3008x1692
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-1cbde886, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/16/47ee53d0-54f0b665.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]

Plugins:
+ apache-commons (34109)
+ changeset-viewer (14)
+ conflation (0.5.7)
+ ejml (34126)
+ geojson (80)
+ geotools (34125)
+ imagery-xml-bounds (34109)
+ jts (34038)
+ opendata (34132)
+ reverter (34109)
+ todo (30303)
+ utilsplugin2 (34109)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss

Last errors/warnings:
- E: 
- E: 
- E: 
- E: 
- E: 
- E: 
- E: 
- E: 
- E: 
- E:

Attachments (0)

Change History (10)

comment:1 Changed 13 months ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 13 months ago by Klumbumbus

Component: CoreCore imagery

comment:3 Changed 13 months ago by Don-vip

Keywords: norway projection added

comment:4 Changed 13 months ago by Don-vip

Milestone: 18.04

We currently choose the first projection:

for (String code : serverProjections) {
    Projection proj = Projections.getProjectionByCode(code);
    if (proj != null) {
        Logging.info(tr("Reprojecting layer {0} from {1} to {2}. For best image quality and performance,"
                + " switch to one of the supported projections: {3}",
                getName(), proj.toCode(), Main.getProjection().toCode(), Utils.join(", ", getNativeProjections())));
        return proj;
    }
}

JOSM needs to be smarter.

comment:5 Changed 13 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13674/josm:

fix #16219 - smarter selection of WMS projection

comment:6 Changed 13 months ago by Klumbumbus

Wouldn't it be even smarter if JOSM checks global projections first and only if there is none available then checks local projections? This would avoid that after adding the imagery you could move the map out of the projection support area.

comment:7 Changed 13 months ago by Don-vip

Sure. But the definition of "global" projection is not so easy. The projection areas are usually quite large, so this problem shouldn't occur for real mapping.

comment:8 Changed 13 months ago by nkamapper

Would it help if I remove the local UTM projections from https://josm.openstreetmap.de/wiki/Maps/Norway, or are they not used for wms_endpoint?

comment:9 Changed 13 months ago by Don-vip

Please keep them. It's up to JOSM to choose the good projection wisely, not to community to restrict the available projections.

comment:10 in reply to:  7 Changed 13 months ago by Klumbumbus

Replying to Don-vip:

Sure. But the definition of "global" projection is not so easy. The projection areas are usually quite large, so this problem shouldn't occur for real mapping.

OK, sounds reasonable.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.