Modify ↓

Opened 8 years ago

Closed 3 years ago

#16172 closed defect (fixed)

[PATCH][GitHub] "Select all unmarked and zoom" function deletes list

Reported by: nkamapper Owned by: Gnonthgol
Priority: normal Milestone:
Component: Plugin todo Version:
Keywords: Cc:

Description

When I use the function "Select all unmarked and zoom", all remaining/unmarked lines disappears.
The whole list is empty, but the header count remains unchanged.

Attachments (0)

Change History (5)

comment:1 by nkamapper, 4 years ago

This is still a problem.

comment:2 by SK53, 3 years ago

Yep, just came to report this. Workaround: when all selected add a new tag (I use my username as a key, which if inadvertently uploaded can easily be deleted). This tag can then be used to recreate the state of the todo list.

comment:3 by taylor.smock, 3 years ago

It looks like ​TodoDialog.java#L146 is the culprit.

I have no clue why that particular code construct was chosen. It seems odd to call Iterator.remove in most for loops.

comment:4 by taylor.smock, 3 years ago

Summary: "Select all unmarked and zoom" function deletes list → [PATCH][GitHub] "Select all unmarked and zoom" function deletes list

PR at ​https://github.com/JOSM/todo/pull/10

comment:5 by taylor.smock, 3 years ago

Resolution: → fixed
Status: new → closed

Fixed in ​c53fb799a36a733d704b2c700b0f15eea3810123.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Gnonthgol.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.