Opened 8 years ago

Last modified 5 years ago

#16147 closed enhancement

Pressurised waterway preset — at Version 8

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 18.06
Component: Internal preset Version:
Keywords: waterway, pressurised, tunnel, pipeline Cc:

Description (last modified by Don-vip)

Recently, waterway=pressurised was reviewed on osm wiki, encouraging the use of waterway=* key to map not only free space but pipe flow waterway features also.
https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dpressurised

Waterway presets should be updated and get new entries as follow :
==Penstock==

  • waterway=pressurised
  • man_made=pipeline
  • substance=water
  • location={underground,overground}
  • usage=penstock
  • name=*
  • operator=*
  • diameter=*
  • material=*

==Pipe flow tunnel==

  • waterway=pressurised
  • usage={headrace,tailrace,transmission,irrigation}
  • location=underground
  • tunnel=flooded
  • name=*
  • operator=*

==Canal preset should be updated as follow==

  • tunnel={culvert,flooded}
  • usage={transportation,transmission,irrigation,headrace,tailrace}

Main validation rules :

  • usage=penstock requires man_made=pipeline and waterway=pressurised
  • tunnel=yes and waterway=pressurised requires man_made=pipeline
  • tunnel=flooded is highly improbable with man_made=pipeline
  • waterway=canal shouldn't be used with tunnel=yes
  • waterway=pressurised requires tunnel=flooded or man_made=pipeline

Render I'd suggest :

  • waterway=pressurised + tunnel=* => add grey 1px casing to existing waterway line
  • waterway=pressurised + man_made=pipeline => add "pipeline color" 1px casing to existing waterway line

I know it's huge and you may have a lot of undergoing business, it would be great to handle this
Let me know if I can help or provide more precise things

Change History (8)

comment:1 by Don-vip, 8 years ago

Milestone: 18.06

comment:2 by Don-vip, 8 years ago

In 13895/josm:

see #16147 - Presets: add penstock, update canal

comment:3 by francois.lacombe, 8 years ago

Hi

Great commit for now with the best icon I could immagine.

Thanks :)

comment:4 by Don-vip, 8 years ago

In 13896/josm:

see #16147 - add usage context as "transmission" is already used for power substations

comment:5 by Don-vip, 8 years ago

You're welcome :) Can you please review French translations tomorrow?

comment:6 by francois.lacombe, 8 years ago

I would if I could find where to go to get preset translations.

Note that transmission substations are tagged with substation=transmission and not usage=transmission
Anyway I don't know if it has any impact yet

comment:7 by anonymous, 8 years ago

One more thing :

I've just noticed there is an existing usage key validation rule called 'missing attribute - usage=* without railway=*'
It should be extended to waterways if possible

comment:8 by Don-vip, 8 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.