Modify

#16007 closed defect (fixed)

Don't raise "missing tag - electrified without railway"

Reported by: bartosomail@… Owned by: team
Priority: normal Milestone: 18.02
Component: Core validator Version:
Keywords: highway railway electrified trolley_wire Cc:

Description

What steps will reproduce the problem?

  1. tag an highway run by a trolley bus with electrified=contact_line
  2. Run validator

What is the expected result?

no warning

What happens instead?

A warning is raised:

"missing tag - electrified without railway"

Please provide any additional information below. Attach a screenshot if possible.

According to:

https://wiki.openstreetmap.org/wiki/Key:electrified

highway=* is a useful combination for electrified=*

Attachments (0)

Change History (6)

comment:1 Changed 13 months ago by Don-vip

Keywords: highway railway electrified added
Priority: trivialnormal

comment:2 Changed 13 months ago by Klumbumbus

Whats the difference to Key:trolley_wire?

comment:3 Changed 13 months ago by bartosomail@…

Good question, unfortunately I cannot answere it.

I see that mention to trolley bus was added to Key:electrified in june 2009:

https://wiki.openstreetmap.org/w/index.php?title=Key%3Aelectrified&type=revision&diff=295574&oldid=233990

while page for Key:trolley_wire was created only later, in december 2009.

I suspect that trolley_wire=yes implies electrified=contact_line.

Maybe I suggest to change the validator to issue the warning "missing tag - electrified without railway" only when there's a tag electrified=contact_line without a tag trolley_wire=yes

and a different warning (stating that electrified=contact_line might be redundant) or no warning at all when both tags trolley_wire=yes and electrified=contact_line are present?

comment:4 Changed 13 months ago by Klumbumbus

Keywords: trolley_wire added; template_report removed
Milestone: 18.02
Version: latest

comment:5 Changed 13 months ago by Klumbumbus

I added cleanup templates to both wiki pages.
Regarding statistics:

  • 44748 ways with trolley_wire=yes on ways with highway=* (we have this tag in our highway presets too)
  • 5560+<1000 ways with electrified=contact_line or eletrified=yes in combination with highway=*

I'll silence the warning for electrified on highways for now. If mappers decide about one tagging method one day we can add a deprecation warning for the other tag.

comment:6 Changed 13 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13452/josm:

fix #16007 - don't warn about electrified=* highway=* combination

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.