Modify

Opened 5 months ago

Closed 4 months ago

#15939 closed enhancement (fixed)

Say what kind of WMS URL verification you are asking for

Reported by: jidanni Owned by: team
Priority: trivial Milestone: 18.04
Component: Core Version:
Keywords: Cc:

Description

When entering a new WMS source, you will see

4. Verify Generated WMS URL
  1. The user looks for a button to push to "verify" it. But there is none.
  2. So perhaps there should be a mouseover "Does the URL look good to you?" or something, else the user won't be clear about what you are asking him to do.

Attachments (0)

Change History (10)

comment:1 Changed 5 months ago by jidanni

http://learnosm.org/en/josm/josm-adding-imagery/ seems to say that the idea is to visually compare the upper box with the lower box.
Fine. I have no opinion.
But do say that is the intention, via a mouseover.

comment:2 Changed 5 months ago by Don-vip

Resolution: worksforme
Status: newclosed

Seems clear enough to me. Feel free to improve the wiki.

comment:3 Changed 5 months ago by Klumbumbus

I see potential to reduce 4 tranlation strings by excluding the numbers and WMS/TMS from the strings.

Currently we have:

        add(new JLabel(tr("1. Enter URL")), GBC.eol());
        add(new JLabel(tr("2. Enter maximum zoom (optional)")), GBC.eol());
        add(new JLabel(tr("3. Verify generated TMS URL")), GBC.eol());
        add(new JLabel(tr("4. Enter name for this layer")), GBC.eol());
        
        add(new JLabel(tr("1. Enter service URL")), GBC.eol());
        add(new JLabel(tr("2. Select layers")), GBC.eol());
        add(new JLabel(tr("3. Select image format")), GBC.eol());
        wmsInstruction = new JLabel(tr("4. Verify generated WMS URL"));
        add(new JLabel(tr("5. Enter name for this layer")), GBC.eol());
        
        add(new JLabel(tr("1. Enter getCapabilities URL")), GBC.eol());
        add(new JLabel(tr("2. Enter name for this layer")), GBC.eol());

It could be e.g.

        add(new JLabel(tr("{0} Verify generated {1} URL", "3.", "TMS")), GBC.eol());

However I'm not sure if this creates problems in other languages, which use other signs than 1,2,3... for numbers. Anyone knows?

comment:4 Changed 5 months ago by Don-vip

I think it's ok to keep "1." for numbers.

comment:5 Changed 5 months ago by jidanni

OK. You confirm the idea is to visually compare the upper box with the lower box.

However if I add that to the wiki, people would say "Well, isn't it a computer program? Can't it compare strings better than I can visually? What if there is a comma in the top box, but a period in the lower box, what are the chances my eye will catch that amongst such long strings?"

comment:6 Changed 5 months ago by Klumbumbus

Non advanced users can verify that JOSM generated an URL after all and then proceed. Advanced users can edit the final WMS URL in this box if they wish.

comment:7 Changed 5 months ago by jidanni

OK. You might want to add a tooltip to that extent.
Otherwise one wouldn't know one could edit it.

comment:8 Changed 5 months ago by jidanni

Because it is called "verify".

comment:9 Changed 4 months ago by Klumbumbus

Milestone: 18.04
Resolution: worksforme
Status: closedreopened

comment:10 Changed 4 months ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 13591/josm:

fix #15939 - improve adding TMS/WMS/WMTS dialog texts, reduce translated strings by 4, add hint to check permission

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.