Opened 7 years ago
Closed 7 years ago
#15939 closed enhancement (fixed)
Say what kind of WMS URL verification you are asking for
Reported by: | jidanni | Owned by: | team |
---|---|---|---|
Priority: | trivial | Milestone: | 18.04 |
Component: | Core | Version: | |
Keywords: | Cc: |
Description
When entering a new WMS source, you will see
4. Verify Generated WMS URL
- The user looks for a button to push to "verify" it. But there is none.
- So perhaps there should be a mouseover "Does the URL look good to you?" or something, else the user won't be clear about what you are asking him to do.
Attachments (0)
Change History (10)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
Seems clear enough to me. Feel free to improve the wiki.
comment:3 by , 7 years ago
I see potential to reduce 4 tranlation strings by excluding the numbers and WMS/TMS from the strings.
Currently we have:
add(new JLabel(tr("1. Enter URL")), GBC.eol()); add(new JLabel(tr("2. Enter maximum zoom (optional)")), GBC.eol()); add(new JLabel(tr("3. Verify generated TMS URL")), GBC.eol()); add(new JLabel(tr("4. Enter name for this layer")), GBC.eol()); add(new JLabel(tr("1. Enter service URL")), GBC.eol()); add(new JLabel(tr("2. Select layers")), GBC.eol()); add(new JLabel(tr("3. Select image format")), GBC.eol()); wmsInstruction = new JLabel(tr("4. Verify generated WMS URL")); add(new JLabel(tr("5. Enter name for this layer")), GBC.eol()); add(new JLabel(tr("1. Enter getCapabilities URL")), GBC.eol()); add(new JLabel(tr("2. Enter name for this layer")), GBC.eol());
It could be e.g.
add(new JLabel(tr("{0} Verify generated {1} URL", "3.", "TMS")), GBC.eol());
However I'm not sure if this creates problems in other languages, which use other signs than 1,2,3... for numbers. Anyone knows?
comment:5 by , 7 years ago
OK. You confirm the idea is to visually compare the upper box with the lower box.
However if I add that to the wiki, people would say "Well, isn't it a computer program? Can't it compare strings better than I can visually? What if there is a comma in the top box, but a period in the lower box, what are the chances my eye will catch that amongst such long strings?"
comment:6 by , 7 years ago
Non advanced users can verify that JOSM generated an URL after all and then proceed. Advanced users can edit the final WMS URL in this box if they wish.
comment:7 by , 7 years ago
OK. You might want to add a tooltip to that extent.
Otherwise one wouldn't know one could edit it.
comment:9 by , 7 years ago
Milestone: | → 18.04 |
---|---|
Resolution: | worksforme |
Status: | closed → reopened |
http://learnosm.org/en/josm/josm-adding-imagery/ seems to say that the idea is to visually compare the upper box with the lower box.
Fine. I have no opinion.
But do say that is the intention, via a mouseover.