Modify

Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#15871 closed enhancement (fixed)

[PATCH] extend preset natural=tree with denotation and circumference

Reported by: bus-mt@… Owned by: team
Priority: normal Milestone: 18.02
Component: Internal preset Version:
Keywords: natural tree denotation circumference Cc:

Description (last modified by Klumbumbus)

The preset for natural=tree misses input fields for circumference and denotation. Below my code for the chunk:

    <chunk id="denotation">
        <combo key="denotation" text="Cycle" values_searchable="true" >
            <list_entry value="landmark" short_description="Trees remarkable due to its size or prominent location, usually visible from great distances and useful for navigation." />
            <list_entry value="natural_monument" short_description="especially old tree, often with a particular shape. Usually protected for its uniqueness" />
            <list_entry value="avenue" short_description="Trees aligned along a road." />
            <list_entry value="urban" short_description="Trees found within settlements, e.g. in parks or spread through residential areas" />
            <list_entry value="agricultural" short_description="Trees in agricultural use." />
        </combo>
    </chunk>

Below the completed code for the item, also added a missing link to Norwegian wiki page.

        <item name="Tree" icon="presets/landmark/trees.svg" type="node" preset_name_label="true">
            <link href="http://wiki.openstreetmap.org/wiki/Tag:natural=tree"
                  cs.href="http://wiki.openstreetmap.org/wiki/Cs:Tag:natural=tree"
                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:natural=tree"
                  es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:natural=tree"
                  fi.href="http://wiki.openstreetmap.org/wiki/Fi:Tag:natural=tree"
                  fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:natural=tree"
                  ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:natural=tree"
                  nl.href="http://wiki.openstreetmap.org/wiki/NL:Tag:natural=tree"
                  no.href="http://wiki.openstreetmap.org/wiki/NO:Tag:natural=tree"
                  pl.href="http://wiki.openstreetmap.org/wiki/Pl:Tag:natural=tree"
                  pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:natural=tree"
                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:natural=tree"
                  uk.href="http://wiki.openstreetmap.org/wiki/Uk:Tag:natural=tree" />
            <label text="A single tree." />
            <space />
            <key key="natural" value="tree" />
            <text key="name" text="Name" />
            <text key="height" text="Height (meters)" />
            <text key="circumference" text="Circumference (meters)" />
            <reference ref="genus_species_taxon" />
            <reference ref="leaf" />
            <reference ref="denotation" />
        </item> <!-- Tree -->

Attachments (1)

defaultpresets.xml (829.7 KB) - added by bus-mt@… 4 months ago.
defaultpresets.xml extended with denotation (chunk at line 274, item at line 10447)

Download all attachments as: .zip

Change History (6)

Changed 4 months ago by bus-mt@…

Attachment: defaultpresets.xml added

defaultpresets.xml extended with denotation (chunk at line 274, item at line 10447)

comment:1 Changed 4 months ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 4 months ago by Klumbumbus

Milestone: 18.02

comment:3 Changed 3 months ago by Don-vip

Keywords: natural tree denotation circumference added
Summary: extend preset natural=tree with denotation and circumference[PATCH] extend preset natural=tree with denotation and circumference

comment:4 Changed 3 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13403/josm:

  • fix #15871 - extend preset natural=tree with denotation and circumference (modified patch by bus-mt)
  • fix jenkins - ignore station=subway

comment:5 Changed 3 months ago by Klumbumbus

Changes I made to the patch:

  • fixed several typos
  • chunk is only useful if used several times
  • added values_context as agricultural was already translated in a different context (access)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.