Modify

Opened 12 months ago

Closed 11 months ago

Last modified 3 months ago

#15818 closed enhancement (wontfix)

[PATCH] Cosmetic code change in ImageryAdjustAction.java

Reported by: skorbut Owned by: skorbut
Priority: minor Milestone:
Component: Core imagery Version:
Keywords: Cc:

Description

While working on https://josm.openstreetmap.de/ticket/15711 I discovered some lines of code in ImageryAdjustAction.java that could need some cosmetic update.

The attached patch should make the code more readable without changing its behaviour.

Attachments (1)

ImageryAdjustAction_cosmetic.patch (1.4 KB) - added by skorbut 12 months ago.

Download all attachments as: .zip

Change History (5)

Changed 12 months ago by skorbut

comment:1 Changed 12 months ago by Don-vip

I think it breaks the code when pressing escape or closing the dialog with close icon. Did you check?

comment:2 Changed 12 months ago by Don-vip

Owner: changed from team to skorbut
Status: newneedinfo

comment:3 Changed 11 months ago by Don-vip

Priority: normalminor

comment:4 Changed 11 months ago by Don-vip

Resolution: wontfix
Status: needinfoclosed

I'm sorry but I really think it breaks some corner cases, and the code is not that complex. I will be happy to accept patches for non-cosmetic tickets :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain skorbut.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.