Modify ↓
#15818 closed enhancement (wontfix)
[PATCH] Cosmetic code change in ImageryAdjustAction.java
| Reported by: | skorbut | Owned by: | skorbut |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Core imagery | Version: | |
| Keywords: | Cc: |
Description
While working on https://josm.openstreetmap.de/ticket/15711 I discovered some lines of code in ImageryAdjustAction.java that could need some cosmetic update.
The attached patch should make the code more readable without changing its behaviour.
Attachments (1)
Change History (5)
by , 7 years ago
| Attachment: | ImageryAdjustAction_cosmetic.patch added |
|---|
comment:1 by , 7 years ago
comment:2 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
comment:3 by , 7 years ago
| Priority: | normal → minor |
|---|
comment:4 by , 7 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | needinfo → closed |
I'm sorry but I really think it breaks some corner cases, and the code is not that complex. I will be happy to accept patches for non-cosmetic tickets :)
Note:
See TracTickets
for help on using tickets.
I think it breaks the code when pressing escape or closing the dialog with close icon. Did you check?