Opened 8 years ago
Last modified 8 years ago
#15734 closed enhancement
Icon and Shortcut checker warnings — at Version 5
| Reported by: | stoecker | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 18.02 |
| Component: | Core | Version: | |
| Keywords: | Cc: | Klumbumbus, Don-vip |
Description (last modified by )
I updated our icon test script and it produced a handful of warnings. I fixed the scanning issues and here is the remaining stuff:
Hmm, on purpose I think
File logo exists twice as .svg and .png.
Should be fixed
ViewBox has float values for statusline/easting.svg: 0 0 57.207973 57.207977 ViewBox has float values for statusline/northing.svg: 0 0 57.207973 57.207977 ViewBox has float values for presets/craft/beekeeper.svg: 0 0 245.05 243.85 ViewBox has float values for presets/craft/painter.svg: 0 0 151.78 195.59 ViewBox has float values for presets/education/library.svg: 244.5 110 489 219.9 ViewBox has float values for presets/education/school.svg: 244.5 110 489 219.9 ViewBox has float values for presets/food/biergarten.svg: 0 0 453.72462 441.64626 ViewBox has float values for presets/food/pub.svg: 0 0 312.24864 359.23141 ViewBox has float values for presets/landmark/forest.svg: 0 0 1118.8397 1227.8107 ViewBox has float values for presets/landmark/reef.svg: 0 0 297.0498 213.31735 ViewBox has float values for presets/landmark/tree_row.svg: 0 0 970.83973 972.18771 ViewBox has float values for presets/landuse/farmland.svg: 0 0 553.9831 553.68453 ViewBox has float values for presets/landuse/meadow.svg: 0 0 253.87779 244.00716 ViewBox has float values for presets/landuse/orchard.svg: 0 0 670.93 802.78 ViewBox has float values for presets/landuse/vineyard.svg: 0 0 317.02 351.393 ViewBox has float values for presets/leisure/billboard.svg: 0 0 976.15625 729.85008 ViewBox has float values for presets/leisure/dogpark.svg: 244.5 110 489 219.9 ViewBox has float values for presets/leisure/fitness_station.svg: 0 0 495.00113 402.08099 ViewBox has float values for presets/leisure/theater.svg: 244.5 110 489 219.9 ViewBox has float values for presets/misc/contact.svg: 0 0 370.3 370.29 ViewBox has float values for presets/religion/hinduism.svg: -0.999 -0.762 242 201 ViewBox has float values for presets/shop/alcohol.svg: 0 0 254.44663 391.01157 ViewBox has float values for presets/shop/beverages.svg: 0 0 383.63842 391.01157 ViewBox has float values for presets/shop/body.svg: 0 0 485.2 493.06 ViewBox has float values for presets/shop/chemist.svg: 0 0 467.496 225.063 ViewBox has float values for presets/shop/clothes.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/copyshop.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/erotic.svg: 0 0 306 288.41 ViewBox has float values for presets/shop/hardware.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/hearing_aids.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/mall.svg: 0 0 208.532 270.512 ViewBox has float values for presets/shop/medical_supply.svg: 0 0 152.92334 167.08995 ViewBox has float values for presets/shop/music.svg: 0 0 432.28 432.28 ViewBox has float values for presets/shop/musical_instrument.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/outdoor.svg: 0 0 218.184 265.487 ViewBox has float values for presets/shop/pet.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/present.svg: 0 0 668.13 692.11 ViewBox has float values for presets/shop/tailor.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/tattoo.svg: 0 0 581.8125 380.1875 ViewBox has float values for presets/shop/travel_agency.svg: 0 0 482.35 402.78 ViewBox has float values for presets/shop/wine.svg: 0 0 115.301 213.549 ViewBox has float values for presets/sightseeing/palaeontological_site.svg: 0 0 95.701 86.146 ViewBox has float values for presets/sport/billiards.svg: 0 0 598.14 598.14 ViewBox has float values for presets/sport/canoe.svg: 0 0 471.17099 413.276 ViewBox has float values for presets/sport/cycling.svg: 0 0 341.14413 298.03736 ViewBox has float values for presets/sport/golf.svg: 0 0 479.32132 510.47299 ViewBox has float values for presets/sport/miniature_golf.svg: 0 0 518.44158 510.47299 ViewBox has float values for presets/sport/racquetball.svg: 0 0 360.94283 366.95856 ViewBox has float values for presets/sport/running.svg: 0 0 289.64 289.64 ViewBox has float values for presets/sport/scuba_diving.svg: 0 0 100 83.101 ViewBox has float values for presets/sport/skiing.svg: 0 0 340.4894 378.98999 ViewBox has float values for presets/sport/soccer.svg: 0 0 105.66 100.619 ViewBox has float values for presets/sport/swimming.svg: 0 0 330.55416 250.32263 ViewBox has float values for presets/sport/tennis.svg: 0 0 381.20159 342.59891 ViewBox has float values for presets/misc/information/information.svg: 0 0 12.5915 12.5915 ViewBox has float values for presets/shop/groceries/bakery.svg: 244.5 110 489 219.9 ViewBox has float values for presets/shop/groceries/cheese.svg: 0 0 139.18741 104.05425 ViewBox has float values for presets/shop/groceries/seafood.svg: 244.5 110 489 219.9
These are commented as "to be created".
File gpx_segmented_track_to_tracks(.svg|.png) does not exist! File gpx_split_tracks_to_layers(.svg|.png) does not exist! File gpx_tracks_to_segmented_track(.svg|.png) does not exist!
These are unused I think. Didn't find a reference for them. Move to images_nodist?
gps-lines.png layer-switcher-maximize.png layer-switcher-minimize.png
Shortcut check complains about following (probably too many lines used for specifying the shortcut):
ERROR src_plugins/OSMRecPlugin/src/org/openstreetmap/josm/plugins/osmrec/OSMRecPluginHelper.java#1728 Shortcut.registerShortcut(scKey, tr("Choose recent tag {0}", count), KeyEvent.VK_0+count, Shortcut.CTRL);final JosmAction action = new JosmAction(scKey, null, "Use this tag again", sc, false) {@Override
ERROR src_plugins/OSMRecPlugin/src/org/openstreetmap/josm/plugins/osmrec/OSMRecPluginHelper.java#1738 Shortcut.registerShortcut(scsKey, tr("Apply recent tag {0}", count), KeyEvent.VK_0+count, Shortcut.CTRL_SHIFT);final JosmAction actionShift = new JosmAction(scsKey, null, "Use this tag again", scs, false) {@Override
ERROR src_plugins/CustomizePublicTransportStop/src/ru/rodsoft/openstreetmap/josm/plugins/customizepublictransportstop/CustomizeStopAction.java#63 Shortcut.registerShortcut("tools:customizestop", tr("Tool: {0}", tr(CUSTOMIZE_STOP_ACTION_MENU_NAME)),KeyEvent.VK_U, Shortcut.DIRECT), true);action.putValue("help", ht("/Action/CustomizeStopAction"));
ERROR src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/actions/EditHighlightedRelationsAction.java#34 Shortcut.registerShortcut("Edit Highlighted Relation", tr(actionName),KeyEvent.VK_K, Shortcut.ALT),false, "editHighlightedRelations", false);
ERROR src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/actions/EdgeSelectionAction.java#46 Shortcut.registerShortcut("mapmode:edge_selection",tr("Mode: {0}", tr(MAP_MODE_NAME)),KeyEvent.VK_K, Shortcut.CTRL),
ERROR src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/actions/AddStopPositionAction.java#59 Shortcut.registerShortcut("mapmode:stop_position",tr("Mode: {0}", tr(MAP_MODE_NAME)),KeyEvent.VK_K, Shortcut.CTRL_SHIFT),
ERROR src_plugins/Mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryDownloadViewAction.java#38 Shortcut.registerShortcut("Mapillary area", I18n.tr(DESCRIPTION),KeyEvent.VK_PERIOD, Shortcut.SHIFT
ERROR src_plugins/Mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportAction.java#31 * @see Shortcut#registerShortcut(String, String, int, int)*/public MapillaryImportAction() {
ERROR src_plugins/Mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillarySubmitCurrentChangesetAction.java#51 Shortcut.registerShortcut("Submit changeset to Mapillary", I18n."Submit the current changeset to Mapillary",KeyEvent.CHAR_UNDEFINED, Shortcut.NONE
Change History (5)
comment:1 by , 8 years ago
| Cc: | added |
|---|---|
| Description: | modified (diff) |
| Summary: | Icon checker warnings → Icon and Shortcut checker warnings |
comment:3 by , 8 years ago
@Vincent:
Probably the results of these 2 scripts should be tested in JOSM-Integration? The Shortcut result file is in "auto/" directory, the other can be started for the tests.
comment:5 by , 8 years ago
| Description: | modified (diff) |
|---|
Sure. What is the script, and how do I call it?
- geticons.pl in JOSM core ;-) Probably filtering the first line?
- And the other one is: ERROR lines in shortcuts.txt in josm's "auto" directory
Note:
See TracTickets
for help on using tickets.
ERROR src_plugins/OSMRecPlugin/src/org/openstreetmap/josm/plugins/osmrec/OSMRecPluginHelper.java#1728 Shortcut.registerShortcut(scKey, tr("Choose recent tag {0}", count), KeyEvent.VK_0+count, Shortcut.CTRL);final JosmAction action = new JosmAction(scKey, null, "Use this tag again", sc, false) {@Override ERROR src_plugins/OSMRecPlugin/src/org/openstreetmap/josm/plugins/osmrec/OSMRecPluginHelper.java#1738 Shortcut.registerShortcut(scsKey, tr("Apply recent tag {0}", count), KeyEvent.VK_0+count, Shortcut.CTRL_SHIFT);final JosmAction actionShift = new JosmAction(scsKey, null, "Use this tag again", scs, false) {@Override ERROR src_plugins/CustomizePublicTransportStop/src/ru/rodsoft/openstreetmap/josm/plugins/customizepublictransportstop/CustomizeStopAction.java#63 Shortcut.registerShortcut("tools:customizestop", tr("Tool: {0}", tr(CUSTOMIZE_STOP_ACTION_MENU_NAME)),KeyEvent.VK_U, Shortcut.DIRECT), true);action.putValue("help", ht("/Action/CustomizeStopAction")); ERROR src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/actions/EditHighlightedRelationsAction.java#34 Shortcut.registerShortcut("Edit Highlighted Relation", tr(actionName),KeyEvent.VK_K, Shortcut.ALT),false, "editHighlightedRelations", false); ERROR src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/actions/EdgeSelectionAction.java#46 Shortcut.registerShortcut("mapmode:edge_selection",tr("Mode: {0}", tr(MAP_MODE_NAME)),KeyEvent.VK_K, Shortcut.CTRL), ERROR src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/actions/AddStopPositionAction.java#59 Shortcut.registerShortcut("mapmode:stop_position",tr("Mode: {0}", tr(MAP_MODE_NAME)),KeyEvent.VK_K, Shortcut.CTRL_SHIFT), ERROR src_plugins/Mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryDownloadViewAction.java#38 Shortcut.registerShortcut("Mapillary area", I18n.tr(DESCRIPTION),KeyEvent.VK_PERIOD, Shortcut.SHIFT ERROR src_plugins/Mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportAction.java#31 * @see Shortcut#registerShortcut(String, String, int, int)*/public MapillaryImportAction() { ERROR src_plugins/Mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillarySubmitCurrentChangesetAction.java#51 Shortcut.registerShortcut("Submit changeset to Mapillary", I18n."Submit the current changeset to Mapillary",KeyEvent.CHAR_UNDEFINED, Shortcut.NONE ERROR src_plugins/rex/src/org/openstreetmap/josm/plugins/rex/actions/TagRoundaboutAction.java#65 Shortcut.registerShortcut("menu:rex","Menu: Roundabout Expander", ERROR src_plugins/indoorhelper/src/controller/IndoorHelperController.java#113 Shortcut.registerShortcut("mapmode:space",tr(""), KeyEvent.VK_SPACE, Shortcut.DIRECT);this.SpaceAction = new SpaceAction(); ERROR src_plugins/indoorhelper/src/controller/IndoorHelperController.java#118 Shortcut.registerShortcut("mapmode:ALT",tr(""), KeyEvent.VK_ENTER, Shortcut.DIRECT);this.EnterAction = new EnterAction();