double imagery entry

[Klumbumbus]

You changed/added some imageries today. For norway there is the same url in two different entries. Could you please check this? Thanks.

http://openwms.statkart.no/skwms1/wms.vegnett?FORMAT=image/png&TRANSPARENT=TRUE&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=all&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}

in Kartverket Sjøkart and Kartverket Vegnett

[nkamapper]

Thank you, fixed.

[Klumbumbus]

Thanks for your additions to the maps pages. Please keep the following in mind:

• always make sure that the OSM community is allowed to trace from the source
• use english names only, the translation is done via ​Launchpad
• for TMS sources use {zoom} instead of {z}
• for sources based on OSM data we usually use <valid-georeference>true</valid-georeference> to suppress the warning message about imagery offset.
• please use shapes instead of only bounds. This is important because sources are automatically added to the imagery menu when the mapview is within the area of a source. So with large bounding boxes, you get the source suggested although it is maybe not available in this area. I created an example for the source at Maps/Finland. It is sufficient to make the shape this rough like in the example, but can be finer too. To easily create the shape code install the ​Imagery-XML-Bounds Plugin, create the boundary way in josm, right click on it in the selection dialog and click on XML Imagery bounds. Then you can copy the bounds and shape code from there.

[nkamapper]

Thank you for your helpful comments.

• always make sure that the OSM community is allowed to trace from the source

Done, they are according to our local wiki and with permission from the data owner. I made one change after further verification with the community over the weekend.

• use english names only, the translation is done via ​Launchpad

Ok, thank you for clarifying, and I will provide translations there. The lang="no" names does not work in JOSM at my end anyway.

• for TMS sources use {zoom} instead of {z}

Thank you for fixing one omission.

• for sources based on OSM data we usually use <valid-georeference>true</valid-georeference> to suppress the warning message about imagery offset.

I have only set to true for imagery directly derived from OSM or from the National Mapping Authority (Kartverket), which does not have any offset, so should be ok.

• please use shapes instead of only bounds. This is important because sources are automatically added to the imagery menu when the mapview is within the area of a source. So with large bounding boxes, you get the source suggested although it is maybe not available in this area. I created an example for the source at Maps/Finland. It is sufficient to make the shape this rough like in the example, but can be finer too. To easily create the shape code install the ​Imagery-XML-Bounds Plugin, create the boundary way in josm, right click on it in the selection dialog and click on XML Imagery bounds. Then you can copy the bounds and shape code from there.

Ok, I will produce the shapes.
This functionality has never worked in JOSM at any of my three computers. I always get the entire global list. Not sure why.

[Don-vip]

Replying to nkamapper:

Ok, I will produce the shapes.
This functionality has never worked in JOSM at any of my three computers. I always get the entire global list. Not sure why.

I'm the maintainer of this plugin, could you please create a new bug report with a step-by-step description? I'll have a look.

[stoecker]

Replying to nkamapper:

• use english names only, the translation is done via ​Launchpad

Ok, thank you for clarifying, and I will provide translations there. The lang="no" names does not work in JOSM at my end anyway.

Well, Norsk is below the minimum limit, so translations are ignored ATM (until someone improves Norsk translation essentially).

• for TMS sources use {zoom} instead of {z}

Thank you for fixing one omission.

We get warnings about these :-)

Ok, I will produce the shapes.
This functionality has never worked in JOSM at any of my three computers. I always get the entire global list. Not sure why.

You always see them all in the settings (with bounds shown in the map). But the entries auto-added to the imagery menu during runtime rely on the bounds.

[nkamapper]

You always see them all in the settings (with bounds shown in the map). But the entries auto-added to the imagery menu during runtime rely on the bounds.

Ok, so no bug. Just have not seen them in the menu until now because the list have been empty here in the North :-)

[stoecker]

P.S. If you can encourage Norsk users (including yourself) to complete the translation we are happy to re-add the language. It already was in JOSM in the past, but was unmaintained and falling back. Its a big task for a single person, but even that has been done before (Japanese if I remember: 100% by one guy in about 10 days).

[stoecker]

Replying to stoecker:

P.S. If you can encourage Norsk users (including yourself) to complete the translation we are happy to re-add the language. It already was in JOSM in the past, but was unmaintained and falling back. Its a big task for a single person, but even that has been done before (Japanese if I remember: 100% by one guy in about 10 days).

No, I mixed that up. That was Turkish. Norsk is still included as "Norsk Bokmål" (nb). I don't know differences between no and nb. Anyway "nb" also needs updates (or "no" :-)

[Don-vip]

It's often useful to remind local mailing lists that JOSM requires translation. I did that a few weeks ago on French mailing list and a single guy translated the ~500 missing strings, we're now at 100% for the first time in many years :)

[Klumbumbus]

Replying to nkamapper:

I have only set to true for imagery directly derived from OSM or from the National Mapping Authority (Kartverket), which does not have any offset, so should be ok.

Right. It seems I overlooked that attribute.

[Klumbumbus]

After you made changes to the maps entries you can have a look at ImageryCompare. If there are red entries in the large list then much likely something was wrong (e.g. z instead of zoom or discrepancies between bounds and shape).

[nkamapper]

Now I have done the translations. Not showing up until tomorrow if I have understood it correctly.
There is one entry with red line - I adjusted the English name and description. Not sure why it is red.

[Klumbumbus]

The page also compares the entries with them at ​https://github.com/osmlab/editor-layer-index. You changed one of the imagico entries. Please don't change them. There are a lot of them and all follow the same naming and description format, which is directly provided by ​http://www.imagico.de/.

[nkamapper]

Ok, will revert it.

[nkamapper]

Done, and ok/not red it seems.

[nkamapper]

I have updated shapes and they seem to be ok.
I have also made translations for Norwegian Bokmål in Launchpad, however, they are not showing up in JOSM, which is also set to Norwegian Bokmål, even after 1-3 days. Is there a long lag after Launchpad updates?

[stoecker]

I have also made translations for Norwegian Bokmål in Launchpad, however, they are not showing up in JOSM, which is also set to Norwegian Bokmål, even after 1-3 days. Is there a long lag after Launchpad updates?

Yes. Sorry. Although they are server related these texts are actually kept in the normal JOSM translation. They will only be updated with next core I18n update. That's sub-optimal, but not so easy changeable ATM.

[Klumbumbus]

Replying to stoecker:

next core I18n update

(Which means in practice much likely shortly before the next stable release at the end of the month.)

[nkamapper]

Ok, I understand. I actually think it would be a lot easier to provide the Norwegian names for the maps with the lang 'nb' option instead of using Launchpad. Syncing is quite cumbersome - a new translation must be provided each time the English version has been slightly altered. I do not think anyone would be interested in providing other translations for Norway anyway. In Central Europe and elsewhere the situation could be different of course, so Launchpad in general is more flexible, however perhaps not necessary in this case.
I will anyway look into the other missing JOSM translations for the application.

[stoecker]

You can do both if you want. The automatic way will be there, but local provided translations also. There is no sync in any way ATM (and the two could even be different). While syncing would be possible it was not worth the effort to develop the necessary tools. So until a big demand comes up we have to live with the current situation ;-)

[Klumbumbus]

This <description lang="en">Trails from the Norwegian database of "Tur og Friluftsruter". Selectable categories for foot, bike and ski trails.</description> at Maps/Norway causes trouble in launchpad as the string is cut at the first ". Not sure which way is the best to fix this.

[Klumbumbus]

the following too:

• <description lang="en">Historic maps - for the time being "Amtskartserien" 1826-1917.</description>
• <description lang="en">Official administrative boundaries at the country, county, municipality and borough ("grunnkrets") levels.</description>
• <description lang="en">Real estate boundaries from the official land register ("matrikkelen"). Monthly update.</description>

[nkamapper]

Replaced " with `and ´

[stoecker]

Fixed parsing in [o33940].

[anonymous]

Ticket #15655 has been marked as a duplicate of this ticket.