after updating tags on a few nodes, saved, then tried to upload

[michaelinredhill]

What steps will reproduce the problem?

1. after updating tags on a few nodes, & move several nodes& insert about 6 nodes into a way tagged as waterway = river
2. save overwriting an existing file.
3. upload

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

version 13163
java version 1.8.0_151
linux mint 18.2

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-11-25 17:20:10 +0100 (Sat, 25 Nov 2017)
Build-Date:2017-11-25 16:26:44
Revision:13162
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13162 en_GB) Linux Mint 18.2 Sonya
Memory Usage: 426 MB / 1744 MB (235 MB allocated, but free)
Java version: 1.8.0_151-8u151-b12-0ubuntu0.16.04.2-b12, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u151-b12-0ubuntu0.16.04.2
WebStart package: icedtea-netx:amd64-1.6.2-3ubuntu1
VM arguments: [-Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- E: Handled by bug report queue: java.lang.NullPointerException

[michaelinredhill]

screenshot of error message

[anonymous]

I'm getting an NPE when trying upload too:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-11-25 17:20:10 +0100 (Sat, 25 Nov 2017)
Build-Date:2017-11-25 16:26:44
Revision:13162
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13162 da) Linux openSUSE Leap 42.2
Memory Usage: 1266 MB / 1324 MB (342 MB allocated, but free)
Java version: 1.8.0_151-b12, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1200
Maximum Screen Size: 1920x1200
Java package: java-1_8_0-openjdk:x86_64-1.8.0.151
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (33882)
+ ImproveOsm (122)
+ InfoMode (33722)
+ Mapillary (v1.5.8)
+ OpeningHoursEditor (33876)
+ SimplifyArea (33004)
+ apache-commons (33668)
+ apache-http (32699)
+ buildings_tools (33735)
+ ejml (32680)
+ fieldpapers (v0.4.3)
+ geotools (33380)
+ gpxfilter (33885)
+ jts (32699)
+ measurement (33760)
+ photo_geotagging (33878)
+ photoadjust (33746)
+ rasterfilters (33893)
+ reverter (33865)
+ splinex (33844)
+ tageditor (33806)
+ tagging-preset-tester (33898)
+ todo (30303)
+ undelete (33835)
+ utilsplugin2 (33742)
+ wikipedia (33696)

Tagging presets:
+ ${HOME}/Dokumenter/DanishChainsPresets.xml
+ ${HOME}/Dokumenter/HjartsPresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/SentieriItaliani&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DK.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- E: Handled by bug report queue: java.lang.NullPointerException


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (19) of main
java.lang.NullPointerException
	at org.openstreetmap.josm.data.APIDataSet.init(APIDataSet.java:101)
	at org.openstreetmap.josm.data.APIDataSet.init(APIDataSet.java:87)
	at org.openstreetmap.josm.data.APIDataSet.<init>(APIDataSet.java:122)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:300)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6533)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3315)
	at java.awt.Component.processEvent(Component.java:6298)
	at java.awt.Container.processEvent(Container.java:2236)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2294)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
	at java.awt.Container.dispatchEventImpl(Container.java:2280)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[Don-vip]

In 13164/josm:

fix #15596 - NPE