Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#15474 closed enhancement (fixed)

[PATCH] Include WhoDidIt in changeset history

Reported by: naoliv Owned by: team
Priority: normal Milestone: 17.10
Component: Core Version:
Keywords: changeset Cc: simon04

Description

Include WhoDidIt (which is also entitled as "OSM Changeset Analyzer") and sort the list.

  • src/org/openstreetmap/josm/gui/history/OpenChangesetPopupMenu.java

     
    5252
    5353    private static final List<ChangesetViewerEntry> DEFAULT_ENTRIES = Arrays.asList(
    5454            new ChangesetViewerEntry(tr("View changeset in web browser"), Main.getBaseBrowseUrl() + "/changeset/{0}"),
     55            new ChangesetViewerEntry(tr("Open {0}", "achavi (Augmented OSM Change Viewer)"), "https://overpass-api.de/achavi/?changeset={0}"),
     56            new ChangesetViewerEntry(tr("Open {0}", "OSMCha (OSM Changeset Analyzer)"), "https://osmcha.mapbox.com/changesets/{0}"),
    5557            new ChangesetViewerEntry(tr("Open {0}", "OSM History Viewer"), "http://osmhv.openstreetmap.de/changeset.jsp?id={0}"),
    56             new ChangesetViewerEntry(tr("Open {0}", "achavi (Augmented OSM Change Viewer)"), "https://overpass-api.de/achavi/?changeset={0}"),
    57             new ChangesetViewerEntry(tr("Open {0}", "OSMCha (OSM Changeset Analyzer)"), "https://osmcha.mapbox.com/changesets/{0}")
     58            new ChangesetViewerEntry(tr("Open {0}", "WhoDidIt (OSM Changeset Analyzer)"), "http://simon04.dev.openstreetmap.org/whodidit/index.html?changeset={0}&show=1")
    5859    );
    5960
    6061    /**

Attachments (0)

Change History (8)

comment:1 by Don-vip, 6 years ago

Cc: simon04 added
Keywords: changeset added
Milestone: 17.10

comment:2 by Don-vip, 6 years ago

I don't understand: I don't see anything once I go to WhoDidIt. Tried several changesets, I'm missing something.

comment:3 by naoliv, 6 years ago

Using http://simon04.dev.openstreetmap.org/whodidit/index.html?changeset=53236553&show=1 as an example, don't you see anything like this?

https://i.imgur.com/ph5Ntq8.png

in reply to:  3 comment:4 by Don-vip, 6 years ago

Replying to naoliv:

Using http://simon04.dev.openstreetmap.org/whodidit/index.html?changeset=53236553&show=1 as an example, don't you see anything like this?

Yes I do. What do you see for this example? I don't see anything: http://simon04.dev.openstreetmap.org/whodidit/index.html?changeset=15548334&show=1

comment:5 by naoliv, 6 years ago

I can't see it either. I don't know why this happens.
@simon04 might have an answer for us :-)

comment:6 by stoecker, 6 years ago

It shows:

Area is too large, please zoom in (requested: 677768, max: 600000)

comment:7 by Don-vip, 6 years ago

Resolution: fixed
Status: newclosed

In 13041/josm:

fix #15474 - Include WhoDidIt in changeset history (patch by naoliv)

comment:8 by Don-vip, 6 years ago

In 13043/josm:

see #15474 - fix warnings

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.