Modify

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#15261 closed task (fixed)

Delete Presets/WifiHotspots

Reported by: Don-vip Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: Klumbumbus, bcattelino, acha

Description

We cannot have pages such as Presets/WifiHotspots.
It breaks the i18n job horribly.
I'm going to delete it purely and simply.
Here's the history for reference:

This preset (see history of this page) was a mix of wifi and golf and not appropriate for publishing. Also the key "wifihotspot" is not an established osm tag. use internet_access=wlan instead, which is already part of the internal preset.

<?xml version="1.0" encoding="UTF-8"?> 
<presets xmlns="http://josm.openstreetmap.de/tagging-preset-1.0" 
author="tumsi" 
version="0.1.9_2017-09-06"
icon="golf.png"
 
description="Presets for Mapping of Golf Courses"
shortdescription="Golf Courses"
 
de.description="Objektvorlangen zum Mappen von Golfplätzen"
de.shortdescription="Golfplätze"

fr.description="Balises spécifiques aux terrains de golf."
fr.shortdescription="Terrain de golf"

link = "http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course">

        <group name="Wifi Hotspot" icon="wifihotspot.png">
                <item name="Wifi Hotspot" type="relation,closedway,node" de.name="Golfplatz" fr.name="Terrain de golf" icon="wifihotspot.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="A golf course is a place or area where you can play golf" />
                        <space />
                        <key key="leisure" value="golf_course"/>
                        <text key="name" text="Name" />
                </item>
                <item name="Bunker" de.name="Bunker" fr.name="Bunker" type="closedway" icon="bunker.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="A type of hazard, also known as a sand trap, which is a depression in the ground filled with sand" />
                        <space />
                        <key key="golf" value="bunker"/>
                        <key key="natural" value="sand"/>
                </item>
                <item name="Water hazard" de.name="Frontales Wasserhindernis" fr.name="Obstacle d'eau frontal" type="closedway,node" icon="water_hazard.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Usually defined by yellow stakes or lines (Rule 26)" />
                        <space />
                        <key key="golf" value="water_hazard"/>
                        <key key="natural" value="water"/>
                </item>
                <item name="Lateral water hazard" de.name="Seitliches Wasserhindernis" fr.name="Obstacle d'eau latéral" type="closedway" icon="lateral_water_hazard.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Usually defined by red stakes or lines (Rule 26)" />
                        <space />
                        <key key="golf" value="lateral_water_hazard"/>
                        <key key="natural" value="water"/>
                </item>
                
                <item name="Tee box (node)" de.name="Abschlagzone (Punkt)" fr.name="Aire de départ (noeud)" type="node" icon="tee.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Area where play begins on a golf hole. Be aware there may be up to 4 tee boxes on a given hole, often with significant displacement from each other, and sometimes approaching the green from different directions. These are usually denoted by colours (most commonly blue, white and red, but may also be green, yellow, black) and names (Championship, Members, Womens)" />
                        <space />
                        <key key="golf" value="tee"/>
                </item>
                <item name="Tee box" de.name="Abschlagzone" fr.name="Aire de départ" type="closedway" icon="teebox.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Area where play begins on a golf hole. Be aware there may be up to 4 tee boxes on a given hole, often with significant displacement from each other, and sometimes approaching the green from different directions. These are usually denoted by colours (most commonly blue, white and red, but may also be green, yellow, black) and names (Championship, Members, Womens)" />
                        <space />
                        <key key="golf" value="tee"/>
                        <key key="landuse" value="grass"/>
                </item>
                
                <item name="Pin" de.name="Loch" type="node" fr.name="Drapeau (trou)" icon="pin.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Location of the hole" />
                        <space />
                        <key key="golf" value="pin"/>
                        <text key="ref" text="Ref"   />
                </item>
                
                <item name="Way to hole" de.name="Weg in das Loch" fr.name="Trou" type="way,closedway" icon="hole.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Way to the hole (ideal line), or entire part of the golf course which is in play for the hole (encompass, the tee boxes, fairways, bunkers and the green)" />
                        <space />
                        <key key="golf" value="hole"/>
                        <text key="name" text="Name"   />
                        <text key="ref" text="Ref"   />
                        <text key="par" text="Par"   />
                        <combo key="handicap" text="handicap rating" de.text="Handicapbewertung" values="1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18"   />
                        <text key="dist:black" text="distance from tee (black)" de.text="Entfernung vom Tee (schwarz)"   />
                        <text key="dist:gold" text="distance from tee (gold)" de.text="Entfernung vom Tee (gold)"   />
                        <text key="dist:yellow" text="distance from tee (yellow)" de.text="Entfernung vom Tee (gelb)"   />
                        <text key="dist:blue" text="distance from tee (blue)" de.text="Entfernung vom Tee (blau)"   />
                        <text key="dist:white" text="distance from tee (white)" de.text="Entfernung vom Tee (weiß)"   />
                        <text key="dist:red" text="distance from tee (red)" de.text="Entfernung vom Tee (rot)"   />
                        <text key="dist:green" text="distance from tee (green)" de.text="Entfernung vom Tee (grün)"   />
                </item>
                
                <item name="Putting green" de.name="Grün" fr.name="Green" type="closedway" icon="green.png"  preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="The area of short grass on smooth ground surrounding a hole" />
                        <space />
                        <key key="golf" value="green"/>
                        <key key="landuse" value="grass"/>
                </item>
                <item name="Fairway" de.name="Fairway" fr.name="Fairway" type="closedway" icon="fairway.png"  preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="The area between the tee and green where the grass is cut even and short" />
                        <space />
                        <key key="golf" value="fairway"/>
                        <key key="landuse" value="grass"/>
                </item>
        <item name="Practice" type="closedway" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Area where golfers can practice" />
                        <space />
                        <key key="golf" value="practice"/>
                        <key key="landuse" value="grass"/>
                </item>
                <item name="Rough" de.name="Rough" fr.name="Rough" type="closedway" icon="rough.png" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Areas within bounds which have longer length of grass" />
                        <space />
                        <key key="golf" value="rough"/>
                        <key key="natural" value="grassland"/>
                </item>
                <item name="Driving range" type="closedway" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="A driving range is an area where golfers can practice their golf swing"  />
                        <space />
                        <key key="golf" value="driving_range"/>
                </item>
                <item name="Club House" type="closedway" preset_name_label="true">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="The building dedicated as a clubhouse" />
                        <space />
                        <key key="golf" value="clubhouse"/>
                        <key key="building" value="yes"/>
                </item>         
                <item name="Golf Course" icon="golf.png" type="relation" preset_name_label="true" >
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course"/>
                        <label text="Relation englobing all holes of this course. If golf club has more than 1 course, specify different names, i.e. - 9 holes and ... - 18 holes" />
                        <space />
                        <key key="type" value="golf_course" />
                <text key="name" text="Name" fr.text="Nom du parcours"   />
                <optional>
                                        <text key="cr:black" text="course rating (black)"   />
                                        <text key="sr:black" text="slope rating (black)"   />
                                        <text key="cr:gold" text="course rating (gold)"   />
                                        <text key="sr:gold" text="slope rating (gold)"   />
                                        <text key="cr:yellow" text="course rating (yellow)"   />
                                        <text key="sr:yellow" text="slope rating (yellow)"   />
                                        <text key="cr:blue" text="course rating (blue)"   />
                                        <text key="sr:blue" text="slope rating (blue)"   />
                                        <text key="cr:white" text="course rating (white)"   />
                                        <text key="sr:white" text="slope rating (white)"   />
                                        <text key="cr:red" text="course rating (red)"   />
                                        <text key="sr:red" text="slope rating (red)"   />
                                        <text key="cr:green" text="course rating (green)"   />
                                        <text key="sr:green" text="slope rating (green)"   />
                        </optional>
                        <roles>
                                <role key="hole" text="Holes" fr.text="Trous" requisite="required" type="way,closedway" count="18" />
                        </roles>
            </item>
        </group>

</presets>

Attachments (0)

Change History (16)

comment:1 Changed 20 months ago by Don-vip

Resolution: fixed
Status: newclosed

comment:2 in reply to:  description Changed 20 months ago by Klumbumbus

Replying to Don-vip:

It breaks the i18n job horribly.

OK, I didn't know that.

comment:3 Changed 20 months ago by Klumbumbus

Cc: bcattelino acha added

comment:4 Changed 20 months ago by stoecker

It breaks the i18n job horribly.

In which way?

comment:5 Changed 20 months ago by Klumbumbus

The page is back. This time cleaned up. However the tag it uses (leisure=wifi_hotspot) is used 0 times in the database. I don't think it is good to have such a preset in our list. How to proceed?

comment:6 Changed 20 months ago by Klumbumbus

(There is already internet_access=wlan in our internal preset.)

comment:7 in reply to:  4 ; Changed 20 months ago by Don-vip

Replying to stoecker:

It breaks the i18n job horribly.

In which way?

There is an error on server side and http://josm.openstreetmap.de/josmfile?mode=en is not valid. The i18n scripts can't cope with that and fail.

comment:8 in reply to:  5 Changed 20 months ago by Don-vip

Replying to Klumbumbus:

How to proceed?

Delete it again! A wifi hotspot is not a leisure. The established tag is internet_access=wlan

comment:9 in reply to:  7 Changed 20 months ago by stoecker

Replying to Don-vip:

Replying to stoecker:

It breaks the i18n job horribly.

In which way?

There is an error on server side and http://josm.openstreetmap.de/josmfile?mode=en is not valid. The i18n scripts can't cope with that and fail.

Please be more specific. Which server side. We have so many scripts, that I don't know what needs to be fixed.

comment:10 Changed 20 months ago by Don-vip

I don't know I didn't investigate the issue. But we can simply replace the old contents before deleting the page and the problem will happen again.

comment:11 in reply to:  10 Changed 20 months ago by stoecker

Replying to Don-vip:

I don't know I didn't investigate the issue. But we can simply replace the old contents before deleting the page and the problem will happen again.

Where? Jenkins, josm cron, i18n dir, trac, ...?

comment:12 Changed 20 months ago by Don-vip

This Jenkins job will fail. What it does: ant -file build.xml clean pot update.
The logs are deleted every 4 builds. So every 4 days when no manual run is launched.

comment:13 Changed 20 months ago by stoecker

Irreproducible. Must have been related to something outside the XML code which can't be reproduced without the original page content.

comment:14 in reply to:  13 Changed 20 months ago by Don-vip

Replying to stoecker:

Irreproducible.

How did you try to reproduce? The wiki page is still valid. To reproduce we must edit it, comment the xml code and add free text such as before: "This preset (see history of this page) was a mix of wifi ..."

comment:15 Changed 20 months ago by stoecker

I created another page with the contents from above and later deleted it again :-)
I'm admin, I can do it 😁

comment:16 Changed 20 months ago by Don-vip

OK :) We'll see next time it happens then. It wasn't the first time :)

Last edited 20 months ago by Don-vip (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.