Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15157 closed defect (invalid)

Changes in "Node.java" (josm-core) broke some plugins

Reported by: Binnette Owned by: team
Priority: normal Milestone:
Component: Plugin Version: latest
Keywords: Cc:

Description (last modified by Binnette)

Hi, I can't compile plugin "cadastre-fr" anymore. Since michael2402 have replace "public EastNorth getEastNorth()" by "public EastNorth getEastNorth(Projecting projection)".

Can somebody make plugin cadastre compile again ?
-commit aefd26d0cc98b484cdaca37d1fc77edccac2ddc4
-michael2402 committed on 15 May
-See #13415: Add the ILatLon interface, unify handling of Nodes and Ca…

24 plugins won't compile anymore.

Thanks. Have a nice day

Attachments (0)

Change History (10)

comment:1 Changed 4 years ago by Don-vip

Component: CorePlugin cadastre-fr
Keywords: Core Node.Java removed
Owner: changed from team to pieren
Priority: majornormal

comment:2 Changed 4 years ago by Binnette

Here is the list of the 24 plugins that should not compile anymore :

  1. alignways
  2. buildings_tools
  3. building_generalization
  4. cadastre-fr
  5. CustomizePublicTransportStop
  6. editgpx
  7. ElevationProfile
  8. gpsblam
  9. improve-way
  10. infomode
  11. irsrectify
  12. jts
  13. opendata
  14. pt_assistant
  15. reltoolbox
  16. routing
  17. shapetools
  18. splinex
  19. terracer
  20. tracer
  21. tracer2
  22. utilsplugin2
  23. videomapping
  24. waydownloader
Last edited 4 years ago by Binnette (previous) (diff)

comment:3 Changed 4 years ago by Binnette

Component: Plugin cadastre-frPlugin
Owner: changed from pieren to team

comment:4 Changed 4 years ago by Binnette

Description: modified (diff)

comment:5 Changed 4 years ago by Don-vip

Resolution: invalid
Status: newclosed

Of course they compile. We have a continuous integration server that checks it every night:
https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/lastStableBuild/

Please make sure your SVN copy is up to date and you have compiled JOSM recently, too.

comment:6 Changed 4 years ago by Binnette

I double check that my svn is up to date from https://svn.openstreetmap.org/applications/editors/josm
And I confirm you that plugin cadastre do not compile, error example:

Compiling 41 source files to C:\Users\Binnette\josm\plugins\cadastre-fr\build
C:\Users\Binnette\josm\plugins\cadastre-fr\src\cadastre_fr\Address.java:349: error: method getEastNorth in class Node cannot be applied to given types;

EastNorth A = seg.a.getEastNorth();

required: Projecting
found: no arguments
reason: actual and formal argument lists differ in length

comment:7 Changed 4 years ago by Binnette

Here is the same error with an other plugin: utilsplugin2

compiling sources for C:\Users\Binnette\josm\dist\utilsplugin2.jar ...
Compiling 61 source files to C:\Users\Binnette\josm\plugins\utilsplugin2\build
C:\Users\Binnette\josm\plugins\utilsplugin2\src\org\openstreetmap\josm\plugins\utilsplugin2\actions\AlignWayNodesAction.java:95: error: method getEastNorth in class Node cannot be applied to given types;

double ax = nodes.get(0).getEastNorth().east();

required: Projecting
found: no arguments
reason: actual and formal argument lists differ in length

comment:8 Changed 4 years ago by Binnette

I can't understand how thoses plugins can compile without errors (on jenkins).
Because class Node has only 1 method getEastNorth with one argument

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/osm/Node.java

And those 24 plugins use this method without argument.

Can you please, try to compile from this repo:

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/osm/Node.java

Maybe jenkins do not build those plugins ?

Last edited 4 years ago by Binnette (previous) (diff)

comment:9 Changed 4 years ago by Binnette

Resolution: invalid
Status: closedreopened

comment:10 Changed 4 years ago by Don-vip

Resolution: invalid
Status: reopenedclosed

Well, triple check please, as I'm 100% sure it's working.
The method missing in your case is defined in ILatLon as a default method (new in Java 8). Michael moved it there, he didn't delete it at all:

    /**
     * <p>Replies the projected east/north coordinates.</p>
     *
     * <p>Uses the {@link Main#getProjection() global projection} to project the lan/lon-coordinates.</p>
     *
     * @return the east north coordinates or {@code null} if #is
     */
    default EastNorth getEastNorth() {
        return getEastNorth(Main.getProjection());
    }

Probably you haven't built JOSM properly.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.