#15108 closed defect (fixed)
Spurious 'key inside key' warning for multipolygons
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Milestone: | 17.08 |
Component: | Core validator | Version: | |
Keywords: | template_report mapcss regression | Cc: | bastiK |
Description
What steps will reproduce the problem?
- Create a multipolygon tagged leisure=track.
- Run validation
What is the expected result?
There should be no warning.
What happens instead?
There is warning for leisure inside leisure, reporting the relation and a node from an outer way.
Please provide any additional information below. Attach a screenshot if possible.
Presumably impacts keys other than leisure.
URL:http://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2017-07-30 17:07:42 +0200 (Sun, 30 Jul 2017) Build-Date:2017-07-30 15:14:00 Revision:12542 Relative:URL: ^/trunk Identification: JOSM/1.5 (12542 en) Linux Arch Linux Memory Usage: 704 MB / 711 MB (242 MB allocated, but free) Java version: 1.8.0_144-b01, Oracle Corporation, Java HotSpot(TM) Server VM Screen: :0.0 1280x800 Maximum Screen Size: 1280x800 VM arguments: [-Djosm.restart=true] Dataset consistency test: No problems found Plugins: + Mapillary (v1.5.5) + OpeningHoursEditor (33185) + apache-commons (32994) + apache-http (32699) + buildings_tools (33004) + ejml (32680) + geotools (33380) + jts (32699) + measurement (33088) + opendata (33438) + reverter (33088) + tagging-preset-tester (33004) + todo (30200) + turnrestrictions (33088) + undelete (33480) + utilsplugin2 (33328) + wikipedia (33288) Tagging presets: + ${HOME}/josm/my.presets.xml + ${HOME}/name-suggestion-index/name-suggestions.presets.xml Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Power&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PowerMapping&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1 + ${HOME}/josm/Style.BuildingYes.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1 Validator rules: + ${HOME}/josm/my.validator.mapcss Last errors/warnings: - W: Unable to convert property z-index to type class java.lang.Float: found -1 - W: Unable to convert property z-index to type class java.lang.Float: found -1 - W: Unable to convert property z-index to type class java.lang.Float: found -1 - W: Unable to convert property z-index to type class java.lang.Float: found -1 - W: Unable to convert property z-index to type class java.lang.Float: found -1 - W: Unable to use English input method - W: Unable to use English input method - W: Unable to use English input method - W: Unable to use English input method - W: Unable to use English input method
Attachments (2)
Change History (17)
comment:1 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
comment:2 by , 8 years ago
I too get no error even with your sample file. Please check if you still get the error when you disable your custom mappaint style ${HOME}/josm/Style.BuildingYes.mapcss
and your custom rule ${HOME}/josm/my.validator.mapcss
.
comment:3 by , 8 years ago
Deactivated (but did not remove) the local customizations. Also removed custom presets. Restarted and still got the spurious warning.
comment:4 by , 8 years ago
What happens if you download and validate another track multipolygon, e.g. at https://www.openstreetmap.org/#map=19/50.70419/12.84406?
follow-up: 8 comment:5 by , 8 years ago
Same warning. My initial report was after I had seen it several times, also on other leisure multipolygons (a golf course).
I doubt it matters, but additional information not included above: My JRE is installed via AUR.
comment:6 by , 8 years ago
Do you get a similar warning for https://www.openstreetmap.org/relation/7005977?
comment:7 by , 8 years ago
Cc: | added |
---|---|
Keywords: | mapcss added |
I don't see how the mapCSS rule:
node[tag("leisure") = parent_tag("leisure")] ∈ *[leisure] { throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure"))); group: tr("{0} inside {1}", "leisure", "leisure"); }
can issue a warning if the node does not have any leisure
tag. You're sure about that I imagine?
comment:8 by , 8 years ago
comment:9 by , 8 years ago
Switched to the Arch OpenJDK package. https://www.openstreetmap.org/relation/7005977 warns for building and for tourism.
Before switching I had ran with the Oracle JRE and --skip-plugins and also still had the error.
comment:10 by , 8 years ago
Using https://josm.openstreetmap.de/download/, the spurious warning does not occur until 12542, it isn't present in 12539.
(using command lines like "java -jar josm-snapshot-12539.jar --skip-plugins", having switched various things back on and back to the HotSpot VM)
comment:12 by , 8 years ago
Keywords: | regression added |
---|---|
Milestone: | → 17.08 |
Resolution: | → fixed |
Status: | needinfo → closed |
By following the bug description I got no error, can you please attach a sample .osm file? Thanks.