[Patch] Check runways,aerodromes for missing tags in validator

[maxerickson@…]

They aren't well adapted for global use but the simple rules I use locally flag many easy improvements:

*[aeroway=aerodrome][!faa]{
  group: tr("Airport Tagging");
  throwWarning: tr("Airport without faa code.");
}

*[aeroway=helipad][!faa]{
  group: tr("Airport Tagging");
  throwWarning: tr("Helipad without faa code.");
}

*[aeroway=aerodrome][!icao][faa!~/\d/],
*[aeroway=aerodrome][!iata][faa!~/\d/]{
  group: tr("Airport Tagging");
  throwWarning: tr("Airport without {0} code.", "{1.key}");
}

*[aeroway=runway][!ref],
*[aeroway=runway][!surface]{
  group: tr("Airport Tagging");
  throwWarning: tr("Runway missing {0}.", "{1.key}");
}

The [faa!~/\d/] selector suppresses the warnings for small US airports, where the FAA usually assigns an identifier that contains a number.

​osmwiki:Tag:aeroway=aerodrome
​osmwiki:Tag:aeroway=helipad

[naoliv]

Include [inside("US")] in the faa tests;

Globally icao could be verified if it's /^[A-Z]{4}$/ and iata for /^[A-Z]{3}$/, but overpass isn't helping right now to count how many objects have a wrong icao or iata code (I will update it later)

[naoliv]

Wrong icao count: 501 objects ​http://overpass-turbo.eu/s/qLP (most in USA)
Wrong iata count: 111 objects¹ (most in USA too)

¹ overpass site isn't creating a short link, but just use:

[out:json][timeout:9000];
(
  node["iata"]["iata"!~"^[A-Z]{3}$"];
  way["iata"]["iata"!~"^[A-Z]{3}$"];
  relation["iata"]["iata"!~"^[A-Z]{3}$"];
);
out count;

Maybe create an external validation rule for deeper aeroway analysis?
For example, we could validate if icao starts with a proper character ​https://upload.wikimedia.org/wikipedia/commons/3/3b/ICAO-countries.png

We could see if icao/iata are being used only with aeroway=aerodrome (and not together with the runway), etc

[Klumbumbus]

Hm, there are "pseudo-icao codes", which would end as false positives if checked against /^[A-Z]{4}$/ ​https://en.wikipedia.org/wiki/International_Civil_Aviation_Organization_airport_code#Pseudo_ICAO-codes

[naoliv]

But then it's something else (another code, another acronym, another key, etc) and not ICAO.

[Klumbumbus]

In 15325/josm:

fix #15107 - add various airport validator rules (based on patches by maxerickson and naoliv)

• warn about iata and icao without aeroway=helipad or aeroway=aerodrome
• warn about wrong iata and icao codes
• warn about aeroway=helipad or aeroway=aerodrome without faa (info level, US only)
• warn about aeroway=helipad or aeroway=aerodrome without icao and iata (info level, US only and only if faa does not contain nunbers, which indicates small airports)
• warn about aeroway=runway without ref and surface (info level)
• enhance Helipad preset