Modify

Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#14891 closed defect (fixed)

Error: Incorrect roundabout (highway:primary instead of unclassified)

Reported by: ninjamask Owned by: team
Priority: normal Milestone: 17.06
Component: Core validator Version:
Keywords: roundabout highway Cc:

Description (last modified by Don-vip)

JOSM validator will autofix the roundabout (w10068083) wrongly from primary to unclassified

Attachments (0)

Change History (6)

comment:1 by Don-vip, 7 years ago

Keywords: highway added; validator removed
Milestone: 17.06

comment:2 by Don-vip, 7 years ago

Description: modified (diff)

comment:3 by Don-vip, 7 years ago

Not easy to spot, but the error is in the data. w28508494 and w28508493 should be tagged with highway=primary instead of highway=primary_link. We should add another test to detect invalid links.

comment:4 by Don-vip, 7 years ago

Resolution: fixed
Status: newclosed

In 12312/josm:

fix #14891 - improve roundabout/links validator test

comment:5 by GerdP, 5 years ago

Summary: Error: Incorrect roundabout (highway:primary instead of unclassified)[Patch RFC] Error: Incorrect roundabout (highway:primary instead of unclassified)

Please review:
See also comment:8, I think with v3 I've got the angle calculations right. I've now implemented that a _link road that is connected to a motorway or trunk must have the class of the higher way. Maybe this should depend on country (territories)?

I've also changed the unit test because I think the example in
josm\core\test\data\regress\14891\14891.osm.bz2 should not produce two warnings about wrong highway links.

comment:6 by GerdP, 5 years ago

Summary: [Patch RFC] Error: Incorrect roundabout (highway:primary instead of unclassified)Error: Incorrect roundabout (highway:primary instead of unclassified)

Sorry, changed the wrong ticket :(

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.