[patch] All Inside [testing] invalid selection bug

[bagage]

What steps will reproduce the problem?

1. Select a city boundary relation
2. Add a filter "type:node" and enable it so that nodes are not selectable
3. Use "Select all inside [testing]" (Alt+Shift+I)
4. Filter out (Ctrl+F) with "type:way" and tick "find in selection"

What is the expected result?

Selection contains only ways.

What happens instead?

Selection contains ways and some residual nodes (for me 750 ways, 1500 nodes). I cannot see to whose these nodes belong to.

Please provide any additional information below. Attach a screenshot if possible.

First thing, it's important to have nodes filtered out to reproduce the bug.
Second thing, you can "fix" the issue by disable the node filter, then reenable it (this will "refresh" the selection and removes nodes).
Third thing, if you have 2 layers, you can also "fix" the issue by switching between the 2 layers.

Basically anything that "refresh" the selection fix the problem.

Build-Date:2017-03-30 17:49:38
Revision:11772
Is-Local-Build:true

Identification: JOSM/1.5 (11772 SVN en) Linux Debian GNU/Linux 9.0 (stretch)
Memory Usage: 844 MB / 1760 MB (572 MB allocated, but free)
Java version: 1.8.0_121-8u121-b13-4-b13, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u121-b13-4
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13
Dataset consistency test: No problems found

Plugins:
+ PicLayer (33148)
+ buildings_tools (33004)
+ conflation (0.5.2)
+ jts (32699)
+ rex (26)
+ todo (30000)
+ utilsplugin2 (33182)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Cannot start IPv4 remotecontrol server on port 8111: Address already in use (Bind failed)
- W: Cannot start IPv6 remotecontrol server on port 8111: Address already in use (Bind failed)
- W: Cannot start IPv4 remotecontrol https server on port 8112: Address already in use (Bind failed)
- W: Cannot start IPv6 remotecontrol https server on port 8112: Address already in use (Bind failed)
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@68aa73d8
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@7292c0c3
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@be5edae
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@6e73bcbf

[bagage]

screenshot of the issue

[bagage]

patch proposal

[bagage]

I attached a proposal patch that fixes the problem by applying filters again after adding "all inside selection".

[bagage]

Even simpler patch borrowed from SelectAllAction.java class :).

[bagage]

patch proposal

[stoecker]

In [o33212:33213].