Build fails because external source src/org/apache/commons/compress/compressors was updated

[holgermappt]

The JOSM build fails due to some issues in src/org/apache/commons/compress/compressors. That dependency seems to be a constant source of trouble. Would it make sense to point to a fixed revision instead of HEAD for that external resource to have more control?

Buildfile: /home/josm/core/build.xml

init-properties:

init:

javacc:

compile:
    [javac] Compiling 358 source files to /home/josm/core/build
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:33: error: package org.apache.commons.compress.utils does not exist
    [javac] import org.apache.commons.compress.utils.BitInputStream;
    [javac]                                         ^
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:34: error: package org.apache.commons.compress.utils does not exist
    [javac] import org.apache.commons.compress.utils.CloseShieldFilterInputStream;
    [javac]                                         ^
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:66: error: cannot find symbol
    [javac]     private BitInputStream bin;
    [javac]             ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:231: error: cannot find symbol
    [javac]     private int readNextByte(BitInputStream in) throws IOException {
    [javac]                              ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:382: error: cannot find symbol
    [javac]     private static int bsR(BitInputStream bin, final int n) throws IOException {
    [javac]                            ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:390: error: cannot find symbol
    [javac]     private static boolean bsGetBit(BitInputStream bin) throws IOException {
    [javac]                                     ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:394: error: cannot find symbol
    [javac]     private static char bsGetUByte(BitInputStream bin) throws IOException {
    [javac]                                    ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:398: error: cannot find symbol
    [javac]     private static int bsGetInt(BitInputStream bin) throws IOException {
    [javac]                                 ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:130: error: cannot find symbol
    [javac]         this.bin = new BitInputStream(in == System.in ? new CloseShieldFilterInputStream(in) : in,
    [javac]                        ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:271: error: cannot find symbol
    [javac]         BitInputStream bin = this.bin;
    [javac]         ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:365: error: cannot find symbol
    [javac]         final BitInputStream inShadow = this.bin;
    [javac]               ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:444: error: cannot find symbol
    [javac]         final BitInputStream bin = this.bin;
    [javac]               ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] /home/josm/core/src/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java:553: error: cannot find symbol
    [javac]         final BitInputStream bin = this.bin;
    [javac]               ^
    [javac]   symbol:   class BitInputStream
    [javac]   location: class BZip2CompressorInputStream
    [javac] Note: /home/josm/core/src/oauth/signpost/AbstractOAuthProvider.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 13 errors

BUILD FAILED
/home/josm/core/build.xml:225: Compile failed; see the compiler error output for details.

It works with revision 2248:

Index: src/org/apache/commons/compress
===================================================================
--- src/org/apache/commons/compress     (revision 11568)
+++ src/org/apache/commons/compress     (working copy)

Property changes on: src/org/apache/commons/compress
___________________________________________________________________
Modified: svn:externals
## -1 +1 ##
-compressors https://github.com/apache/commons-compress/trunk/src/main/java/org/apache/commons/compress/compressors
+https://github.com/apache/commons-compress/trunk/src/main/java/org/apache/commons/compress/compressors@2248 compressors

[stoecker]

In r11569.

[stoecker]

In 11569/josm:

fix #14379 - fix apache externals