Remove methods deprecated during gsoc-core

[Don-vip]

Deprecated features from gsoc-core to remove, which are still used in core or plugins:

• LatLon.heading(): used in 5 plugins: improveway, iodb, nanolog, photoadjust, rex
• Preferences.getColor(): used in MapCSSParser + 4 plugins: utilsplugin2, commandLine, routing, graphview
• Layer.isChanged(): used in MapView, GpxLayer, AbstractTileSourceLayer + plugin osminspector
• ImageryLayer.getDx()/getDy()/setOffset()/displace(): used in ApplyOffsetAction, ImageryLayer + 4 plugins: commandLine, imageryadjust, iodb, irsrectify

[michael2402]

I don't have much time right now and won't have until March 31. I would like to re-schedule this one for milestone 17.4 (I just put it to 17.3, since there is no 17.4 yet).

[Don-vip]

ok thanks for the heads up :)

[stoecker]

In 11623/josm:

see #14120 - fix deprecation in core

[Don-vip]

In 11631/josm:

see #14120 - update to JavaCC 7.0.2 - patched to avoid error-prone compilation warnings by removing everything related to ReInit methods in ParseGen.java and SimpleCharStream.template

[Don-vip]

The only warnings in core now concern Layer.isChanged().

[stoecker]

@michael2402:

Can you please give fixing the deprecations highest priority? We need to get a clean state, before we start other deprecations.

[Don-vip]

14.04 is due in two weeks, can you please fix the core deprecation warnings before that?

[Don-vip]

I think I have updated all the plugins now. But it seems we still have a bug in core:

• #13503: IAE: Cannot paint layer, it is not registered (TMSLayer)
• #13604: IAE: Cannot paint layer, it is not registered (OsmDataLayer)
• #13886: IAE: Cannot paint layer, it is not registered (ValidatorLayer)
• #14234: IAE: Cannot paint layer, it is not registered (GeoImageLayer)
• #13589: IAE: Cannot paint layer, it is not registered (ElevationProfileLayer)

[Don-vip]

One week left before 14.04. Because of #14604 impacting lots of users, and with #7427 being fixed, the release date this month will not shift.

[michael2402]

I've been busy the last week, but I have lots of time this one.

[michael2402]

In 12014/josm:

See #14120: Use a listener to get notified of way segment / virtual node highlight changes.

[Don-vip]

Two unit tests are failing.

[michael2402]

I already saw that. Some problem with the test framework removing a layer twice, i'm debugging it but tests always take some time to run ;-)

[Don-vip]

ok thanks :) I tried to fix them but didn't understand the error.

[Don-vip]

In 12020/josm:

see #14120 - checkstyle

[michael2402]

In 12023/josm:

See #14120: Do not overwrite the mapView field for unit tests. Fix map view scale/center.

[michael2402]

In 12024/josm:

See #14120: Fix unit tests by using a separate layer manager when mocking the map view.

[michael2402]

In 12025/josm:

See #14120: Throw a nicer exception if a layer is destroyed twice.

[michael2402]

I found the problem:

The map view handles the layer lifecycle. If tests create multiple map views for the same layer, each map view destroys the layers during test exit - so we have several destroy() calls. I removed one of the places where MapViewMock is used. We could completely remove that Mock, I think.

[Don-vip]

In 12028/josm:

see #14120 - fix java warnings