Modify

Opened 4 years ago

Closed 6 months ago

Last modified 5 months ago

#14088 closed enhancement (fixed)

Add icons to value drop down in adding tag dialog

Reported by: mdk Owned by: team
Priority: normal Milestone: 20.02
Component: Core Version: latest
Keywords: add tag dialog icon Cc:

Description

Since more and more icons for common tag=value combinations are defined and used for preset and specially for the recently used tag list in the add tag dialogue, I realised, that I tend to identity recently used tags by the icons instead of reading the text (especially after changeing the list size from 5 to 20).
When I want to add a tag which is not in the list of recently used tags. I start typing key, hit TAB if I found the wanted value start typing the key and press ENTER when I reach the wanted value.
Sometimes key and especially values have similar names (like natural=scree and natural=scrub). When typing, the shown values depends on

  • are the value is used in a preset?
  • is the value used in the currently downloaded area?
  • did I used the key in the current session recently?

So I can't rely on the characters I typed, but I must always check the current result by reading the text.
Example:
w TAB r ENTER normally results in waterway=river. But when I added a riverbank before the same key sequence results in waterway=riverbank. And when I add water=pond before the same key sequence results in water=reservoir.
Therefore I would find it very helpful to see icons in the drop-down lists either when typing or when selecting from the list. The icons would help me verifying the correct value and to get hints for the most common values. Values without icons are normally uncommon or typos.

Attachments (1)

2020-01-26-234325_566x438_scrot.png (10.1 KB) - added by simon04 7 months ago.

Download all attachments as: .zip

Change History (19)

Changed 7 months ago by simon04

comment:1 Changed 7 months ago by simon04

Keywords: add tag dialog icon added
Milestone: 20.02

What about changing the icon (and label?) of the Okay button?


comment:2 Changed 7 months ago by Klumbumbus

That would make the width of that button changing while typing!? That sounds a bit strange to me. And what about long values, e.g. old_name=Philippine College of Science and Technology - Tayug Campus or longer?

comment:3 Changed 6 months ago by simon04

Resolution: fixed
Status: newclosed

In 15835/josm:

fix #14088 - Add tags dialog: use okay button icon from matching preset/style

comment:4 Changed 6 months ago by gaben

The height of the button is changing with the icon as well. Try it out with building or addr:*. Also the width with eg. description.

comment:5 Changed 6 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened

comment:6 Changed 6 months ago by simon04

I don't see an easy (and performant) way this fix this issue: The icons have different aspect rations (typically 16:16, description.svg has 11:16, housenumber.svg has 16:12).

I'm not going to invest time in harmonizing the displayed icon size (for now). If we cannot live with the current behaviour, I'm going to revert r15835.

comment:7 Changed 6 months ago by mdk

Why not put a "container" around the icon with a fixed (min-)size of 16x16?

comment:8 Changed 6 months ago by simon04

Resolution: fixed
Status: reopenedclosed

In 15889/josm:

fix #14088 - Add tags dialog: use padded preset/style icons for okay button

comment:10 Changed 6 months ago by simon04

In 15895/josm:

see #14088 - Fix SelectionTableCellRendererTest, MemberTableMemberCellRendererTest

comment:11 Changed 6 months ago by simon04

In 15896/josm:

see #14088 - Optimize ImageProvider.getPadded for untagged primitives

comment:12 Changed 6 months ago by simon04

In 15897/josm:

see #14088 - Add ImageProviderTest.testGetPadded

comment:13 Changed 6 months ago by simon04

In 15920/josm:

fix #18764, see #14088 - NPE in findIcon when adding a tag (patch by taylor.smock, extended)

comment:14 Changed 6 months ago by simon04

In 15921/josm:

see #18764, see #14088 - Add non-regression test (patch by taylor.smock)

comment:15 Changed 6 months ago by simon04

In 15927/josm:

see #18764, see #14088 - Add non-regression test (fix for headless)

comment:16 Changed 5 months ago by simon04

In 15946/josm:

fix #18798, see #14088 - Crash when adding junction=roundabout to a node (patch by taylor.smock)

comment:17 Changed 5 months ago by simon04

In 15947/josm:

see #18798, see #14088 - TagEditHelperTest: share code

comment:18 Changed 5 months ago by simon04

In 15948/josm:

see #18798, see #14088 - Add robustness for TagEditHelper.AbstractTagsDialog.findIcon

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.