Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13982 closed enhancement (fixed)

Wrong Links to OSM Website If Different API Is Used

Reported by: Nakaner Owned by: team
Priority: minor Milestone: 16.12
Component: Core Version:
Keywords: Cc:

Description

What steps will reproduce the problem?

  1. Start JOSM
  2. Go to the Preferences, change the API to http://master.apis.dev.openstreetmap.org/api
  3. Download anything (now it is fetched from the Dev API), e.g. node 7489948
  4. Select any downloaded object
  5. Go to View → History (Web)

What is the expected result?

The web browser opens http://master.apis.dev.openstreetmap.org/node/7489948/history

What happens instead?

The web browser opens http://www.openstreetmap.org/node/7489948/history

This bug also occurs if you open a changeset in the web browser from JOSM's history view.

It seems that only external links (which are opened in the web browser) are affected. API queries (e.g. (node|way|relation)/ID/history work as expected.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-06 20:18:38 +0100 (Sun, 06 Nov 2016)
Build-Date:2016-11-06 21:45:03
Revision:11223
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11223 de) Linux Ubuntu 16.04.1 LTS
Memory Usage: 963 MB / 3541 MB (667 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-2ubuntu0.16.04.2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u111-b14-2ubuntu0.16.04.2
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (v1.3.1)
+ OpeningHoursEditor (32699)
+ PicLayer (32796)
+ apache-commons (32699)
+ apache-http (32699)
+ buildings_tools (32944)
+ ejml (32680)
+ geotools (33042)
+ imagery_offset_db (32796)
+ jts (32699)
+ opendata (33051)
+ pdfimport (32796)
+ reverter (32796)
+ utilsplugin2 (32815)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Communication_Towers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&preset&zip=1
+ ${HOME}/Dokumente/OSM/Projekte/0061-university-tagging/university.xml
+ ${HOME}/Entwicklung/OpenRailwayMap/josm-presets/de-avg-signals.xml
+ ${HOME}/Entwicklung/OpenRailwayMap/josm-presets/de.xml
+ ${HOME}/Entwicklung/OpenRailwayMap/josm-presets/de-signals-eso.xml
+ ${HOME}/Entwicklung/OpenRailwayMap/josm-presets/de-signals-bostrab.zip

Map paint styles:
- http://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&style&zip=1
+ ${HOME}/Entwicklung/OpenRailwayMap/styles/josm-additional.mapcss
+ ${HOME}/Entwicklung/OpenRailwayMap/styles/maxspeed.mapcss
+ ${HOME}/Entwicklung/OpenRailwayMap/styles/signals.mapcss
+ ${HOME}/Entwicklung/OpenRailwayMap/styles/standard.mapcss

Validator rules:
+ ${HOME}/Entwicklung/OpenRailwayMap/validator/openrailwaymap.validator.mapcss
+ ${HOME}/Entwicklung/OpenRailwayMap/validator/de-openrailwaymap.validator.mapcss

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'university.png'
- W:  University: Could not get presets icon university.png
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'
- E: Verbindung zur API fehlgeschlagen - <html>Liste der Änderungssätze kann nicht vom OSM-API-Server 'http://master.apis.dev.openstreetmap.org/api/0.6' abgerufen werden.<br>Der Server antwortete mit dem Rückgabewert 404 statt 200.<br>Bitte Schreibweise von 'http://master.apis.dev.openstreetmap.org/api/0.6' kontrollieren und erneut überprüfen.</html>
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryChangesetDialog$SubmitAction@1f07ac73

OSM API: http://master.apis.dev.openstreetmap.org/api

Attachments (0)

Change History (5)

comment:1 Changed 3 years ago by stoecker

Resolution: wontfix
Status: newclosed

The Website can be also be changed: with the "osm.url" parameter (expert options). API and website are two different things. Normally changing the website makes no sense as other API's don't have a webservice like the OSM webpages attached to it.

comment:2 Changed 3 years ago by Nakaner

stoecker wrote:

API and website are two different things. Normally changing the website makes no sense as other API's don't have a webservice like the OSM webpages attached to it.

You know that the website and the API are tied together and it's therefore you usual that an OSM API has a website, don't you?

If an API has no website, it is better to point the user to an URL which will result in an error 404 than pointing him to the obvious wrong URL (website of a different API instance)

The simple solution of this bug is to display a separate input field for the website base URL next to the input field for the URL of the API.

comment:3 Changed 3 years ago by stoecker

Milestone: 16.11
Resolution: wontfix
Status: closedreopened
Type: defectenhancement

comment:4 Changed 3 years ago by simon04

Resolution: fixed
Status: reopenedclosed

In 11262/josm:

fix #13982 - Wrong links to OSM website if different API is used

comment:5 Changed 3 years ago by Don-vip

Milestone: 16.1116.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.