Modify

Opened 4 years ago

Closed 4 years ago

#13923 closed enhancement (fixed)

[Patch] Select the relation instead open ends with "Multipolygon is not closed"

Reported by: naoliv Owned by: team
Priority: normal Milestone: 16.10
Component: Core validator Version:
Keywords: Cc:

Description

Could we have JOSM display/select the broken relations instead the open end nodes?
For example, validate the attached file.

One strange thing is that the validator message says 8 nodes, while when selecting the problem we have 4 nodes.

Selecting the nodes instead the broken relation isn't helpful with some heavily broken relations.

If I am not mistaken, JOSM used to select the broken relation (and display its name in the warning message).

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-05 17:03:06 +0100 (Sat, 05 Nov 2016)
Build-Date:2016-11-06 02:34:59
Revision:11221
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11221 en) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 247 MB / 4029 MB (80 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u111-b14-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (3)

unclosed.osm (1.3 KB) - added by naoliv 4 years ago.
13923.patch (914 bytes) - added by GerdP 4 years ago.
13923_v2.patch (1.0 KB) - added by GerdP 4 years ago.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by naoliv

Attachment: unclosed.osm added

comment:1 Changed 4 years ago by GerdP

Yes, the change was inroduced with r11129. Before the list of primitives contained the relation and the nodes, now it only contains the nodes. I'll fix that in my patch for #13307.
I did not yet find out why it says 8 instead of 4 nodes.

Changed 4 years ago by GerdP

Attachment: 13923.patch added

Changed 4 years ago by GerdP

Attachment: 13923_v2.patch added

comment:2 Changed 4 years ago by GerdP

Summary: Select the relation instead open ends with "Multipolygon is not closed"[Patch] Select the relation instead open ends with "Multipolygon is not closed"

The patch 13923_v2.patch fixes this and similar problems with other multipolygon messages.

comment:3 Changed 4 years ago by Don-vip

Milestone: 16.10

comment:4 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 11222/josm:

fix #13923 - Select the relation instead open ends with "Multipolygon is not closed" (patch by Gerd Petermann)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.