Modify

Opened 4 years ago

Last modified 4 years ago

#13918 new enhancement

Better handle some dialogs marked as "never show again"

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

With any relation (like the one in this example), it's just not possible to delete it anymore.
Opening the relation editor and clicking the delete button, nothing happens.
Selecting the relation in JOSM and pressing Delete, nothing happens.

JOSM

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-04 17:58:48 +0100 (Fri, 04 Nov 2016)
Build-Date:2016-11-05 02:32:23
Revision:11218
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11218 pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 486 MB / 4029 MB (233 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u111-b14-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (32699)
+ Create_grid_of_ways (32699)
+ FastDraw (32938)
+ FixAddresses (32796)
+ ImportImagePlugin (32699)
+ OpeningHoursEditor (32699)
+ PicLayer (32796)
+ SimplifyArea (32796)
+ apache-commons (32699)
+ buildings_tools (32944)
+ download_along (32946)
+ editgpx (32699)
+ ejml (32680)
+ geojson (43)
+ geotools (33042)
+ graphview (32796)
+ jogl (1.0.46)
+ jts (32699)
+ kendzi3d (1.0.191)
+ kendzi3d-resources (0.0.1)
+ log4j (32699)
+ measurement (32936)
+ merge-overlap (32699)
+ opendata (33049)
+ pdfimport (32796)
+ photo_geotagging (32699)
+ poly (32699)
+ reverter (32796)
+ tageditor (33021)
+ tagging-preset-tester (32869)
+ todo (30000)
+ turnlanes-tagging (252)
+ turnrestrictions (32796)
+ undelete (32699)
+ utilsplugin2 (32815)

Attachments (2)

cant-delete-relation.osm (911 bytes) - added by naoliv 4 years ago.
video.mkv (955.1 KB) - added by naoliv 4 years ago.

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by naoliv

Attachment: cant-delete-relation.osm added

comment:1 Changed 4 years ago by naoliv

Tested with releases 10966, 10770 and 10301 and I see the same problem.
Downgraded java to Debian's 8u111 (from 17 days ago) and also 8u102 (from 74 days ago) and I can't delete any relations.

What could be causing this, please?

comment:2 Changed 4 years ago by GerdP

I cannot reproduce the problem, but I see a different problem with your example:
1) Make sure that the Selection window is open (Alt+Shift+T(
2) Select the relation
3) In the Selection Windows use a right click on the relation and select "Edit"
4) Click on the delete icon
5) In the popup "Delete relation ?" click "Yes"

Expected:
Relation is deleted and disappears from the Selection Window
Instead:
Relation is deleted but still appears in the Selection Window, now with "0 members"

Maybe this is what you see as well?

comment:3 Changed 4 years ago by naoliv

See the attached video, please.
I try to delete using the relation editor, using the delete button in the Relations window and also the Delete from the Edit menu.

I can delete other objects, but can't delete any relation.
I am out of ideas of what could be causing this :-/

Changed 4 years ago by naoliv

Attachment: video.mkv added

comment:4 Changed 4 years ago by GerdP

I don't see the dialog to confirm the delete, maybe your preferences file is somehow corrupted?
My file contains these settings:

<tag key='message.delete_relations' value='true'/>

<tag key='message.delete_relations.value' value='0'/>


comment:5 Changed 4 years ago by GerdP

I can reproduce your problem with these settings:

<tag key='message.delete_relations' value='false'/>
<tag key='message.delete_relations.value' value='1'/>

which you get when you select "Don't show this message again" and press no.

comment:6 Changed 4 years ago by naoliv

Priority: majornormal
Summary: Can't delete relation anymoreBetter handle some dialogs marked as "never show again"
Type: defectenhancement

Damn... Indeed. I owe you one beer for this.

I had false and 1 there. It seems that I unintentionally clicked to never ask again.
Does it really make sense to allow to never ask about deleting relations like this?

Could JOSM remove such option for some specific cases (ie, it should never allow to hide such dialogs forever) or could it handle such stupid user case in a better way, please?
I really don't know if there is a valid reason to never show the delete dialog (and make cases like this happen).

comment:7 Changed 4 years ago by naoliv

Keywords: regression removed

comment:8 Changed 4 years ago by GerdP

I also think that the "Don't show again" option makes no sense here, esp. when several dialogs still show an enabled delete button.

comment:9 Changed 4 years ago by simon04

Ticket #12290 is related.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to naoliv
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.