Modify

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#13799 closed enhancement (fixed)

Use builder pattern for TestError

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 16.10
Component: Core Version:
Keywords: refactoring Cc:

Description

The many parameters of TestError constructors make the code hard to read, also causing some tests to write helper methods to create errors. The builder pattern comes to rescue.

Attachments (0)

Change History (7)

comment:1 Changed 3 years ago by simon04

Resolution: fixed
Status: newclosed

In 11129/josm:

fix #13799 - Use builder pattern for TestError

comment:2 Changed 3 years ago by simon04

In 11130/josm:

fix #13800 see #13799 - Fix IAE in TestError

comment:3 Changed 3 years ago by simon04

In 11134/josm:

fix #13807 see #13799 - Regression: zoom to problem doesn't work anymore

comment:4 Changed 3 years ago by simon04

In 11135/josm:

see #13799 - NPE in MultipolygonTest

comment:5 Changed 2 years ago by Don-vip

In 11307/josm:

fix #14040 see #13799 - Regression: primitives collection must support clear operation

comment:6 Changed 2 years ago by Don-vip

In 11309/josm:

see #14015 see #13799 - remove deprecated stuff

comment:7 Changed 2 years ago by simon04

In 11336/josm:

see #13799 see #14040 - Make TestError#getPrimitives return an unmodifiable collection

This also reverts r11307.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.