Modify

Opened 8 years ago

Last modified 3 years ago

#13730 new enhancement

Proposal for three additional attributes for presets

Reported by: simon@… Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: preset attributes status synonyms region Cc: Klumbumbus

Description

This is not directly a request for an addition to JOSM code, however it might be interesting to implement the same concepts in JOSM and adding the attributes to the specification so that presets can continue to be easily used and shared between applications.

The proposed attributes in question would be

"status" with values "active","deprecated" "active" is the default

Currently most of the time deprecated tagging is simply removed from the presets, however this means that objects tagged with the old scheme cannot be matched against a preset, or the "deprecated" status has to be recorded some hoe in the preset name making it difficult to handle the situation in code (for example by suggesting a current variant).

"synonyms" comma separated list of synonyms for the current preset

This mirrors a similar facility in iD and would make both preset search and translations easier.

"region" ISO 3166-1 country or ISO 3166-2 state code

This will enable country/state specific presets, mainly for display purposes and different default values.

Attachments (0)

Change History (7)

comment:1 by Klumbumbus, 8 years ago

Cc: Klumbumbus added

comment:2 by openstreetmap.org-user-d1g, 8 years ago

I suggested "synonyms" some time ago in #12830

Not only we should have synonyms but they should be language-specific (as in iD)

comment:3 by anonymous, 8 years ago

@d1g my basic idea would be that you don't do a literal translation of the string but actually replace it with synonyms in the respective language. What wouldn't be a good idea is to store the translations directly in the preset.

It would naturally be possible to do this in a separate file.

comment:4 by openstreetmap.org-user-d1g, 8 years ago

but actually replace it with synonyms in the respective language

That's how it's done in iD, my point exactly.

What wouldn't be a good idea is to store the translations directly in the preset.

I never said where they should be stored, it's an implementation detail specific to JOSM.

All translations of tags are done inside TX in iD, nobody of translators edits iD code/iD internal presets.

OFC you need intermediate markers to match translations with presets (when you compile TX back with presets)

Last edited 8 years ago by openstreetmap.org-user-d1g (previous) (diff)

comment:5 by skyper, 4 years ago

Keywords: preset attributes status synonyms region added

Is this not a core issue?

comment:6 by SimonPoole, 4 years ago

It might be a core issue or not, what it definitely is, is a blast from the past, things have -long- moved on. See http://vespucci.io/tutorials/presets/#extensions resp. https://github.com/MarcusWolschon/osmeditor4android/blob/master/documentation/docs/tutorials/presets.md (one further attribute), for the current, proven in daily use, state of things.

Foe synonym support in the end I decided to use the synonym files from iD (essentially search matches against a synonym, then uses the base terms from that to find a matching preset), works well and doesn't waste community effort in re-doing yet another configuration file.

comment:7 by skyper, 3 years ago

Component: Internal presetCore

This belongs to core or non existing "Core tagging preset"

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to simon@….
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.