Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13708 closed enhancement (duplicate)

group "role" warnings, "preset doesn't contain property" infos and missing names infos in validator list

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report grouping Cc: simon04, naoliv

Description (last modified by Klumbumbus)

follow up from #12570

validator results missing role and unknown role (are there more?) should each be grouped
also in info level "preset doesn't contain property key" and "preset doesn't contain property value" and the different missing name infos


URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-24 21:53:10 +0200 (Sat, 24 Sep 2016)
Build-Date:2016-09-25 01:36:58
Revision:11051
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11051 de) Windows 7 32-Bit
Memory Usage: 755 MB / 870 MB (81 MB allocated, but free)
Java version: 1.8.0_102-b14, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,900m, -Djnlpx.splashport=51300, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (32699)
+ DirectDownload (32699)
+ DirectUpload (32699)
+ HouseNumberTaggingTool (32699)
+ Mapillary (v1.3.0)
+ OpeningHoursEditor (32699)
+ alignways (32921)
+ apache-commons (32699)
+ apache-http (32699)
+ buildings_tools (32944)
+ editgpx (32699)
+ imagery_offset_db (32796)
+ log4j (32699)
+ measurement (32936)
+ photo_geotagging (32699)
+ photoadjust (32863)
+ reverter (32796)
+ tag2link (32941)
+ tagging-preset-tester (32869)
+ terracer (32699)
+ turnlanes-tagging (245)
+ turnrestrictions (32796)
+ undelete (32699)
+ utilsplugin2 (32815)
+ wikipedia (32884)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ D:\<user.name>\OSM\JOSMSVN\data\defaultpresets.xml
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip

Map paint styles:
+ D:\<user.name>\OSM\JOSMSVN\styles\standard\elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ShowID&zip=1
- D:\<user.name>\OSM\eigene styles\PriorityRoad\PriorityRoad_1.0.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- D:\<user.name>\OSM\TestNew\newicons.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- D:\<user.name>\OSM\patches\old MPs\dataquality.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&style&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- D:\<user.name>\OSM\eigene styles\Tourenplanung.mapcss
- D:\<user.name>\OSM\eigene styles\SpecificBuildingValues\SpecificBuildingValues.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- http://www.openrailwaymap.org/styles/standard.mapcss
- D:\<user.name>\OSM\eigene styles\area-symbol.zip
- http://www.freietonne.de/ft_icons/josm/FreieTonne_rules_presets_zip.php
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/hazmat&zip=1

Validator rules:
+ https://raw.githubusercontent.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ D:\<user.name>\OSM\TestNew\new.validator.mapcss

Last errors/warnings:
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryChangesetDialog$SubmitAction@106e220
- W: couldn't parse wizard input
- E: org.openstreetmap.josm.tools.UncheckedParseException
- E: Auswertungsfehler - <html>The Overpass wizard could not parse the following query:<ul><li>is_in=Plauen; Vogtlandkreis; Chemnitz; Sachsen; Bundesrepublik Deutschland; Europe</li></ul>
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'

Attachments (2)

ungroupedroles.2.png (138.1 KB) - added by Klumbumbus 5 years ago.
missingname.png (155.6 KB) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by Klumbumbus

Description: modified (diff)
Summary: group role errors in validator listgroup "role" warnings and "preset doesn't contain property" infos in validator list

Changed 5 years ago by Klumbumbus

Attachment: ungroupedroles.2.png added

comment:2 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:3 Changed 5 years ago by skyper

+1 for more/better grouping

What annoys myself the most are role warnings not sorted by type=*. e.g. I get warnings about associatedStreet mixed with public_transport.

comment:4 in reply to:  3 Changed 5 years ago by Klumbumbus

Replying to skyper:

What annoys myself the most are role warnings not sorted by type=*. e.g. I get warnings about associatedStreet mixed with public_transport.

See also #11072

comment:5 Changed 5 years ago by Klumbumbus

Cc: simon04 naoliv added

comment:6 Changed 5 years ago by Klumbumbus

Keywords: grouping added

Changed 5 years ago by Klumbumbus

Attachment: missingname.png added

comment:7 Changed 5 years ago by Klumbumbus

Description: modified (diff)
Summary: group "role" warnings and "preset doesn't contain property" infos in validator listgroup "role" warnings, "preset doesn't contain property" infos and missing names infos in validator list

The missing names infos should also be grouped.

comment:8 in reply to:  7 Changed 5 years ago by simon04

Replying to Klumbumbus:

The missing names infos should also be grouped.

This should be fixed due to #13798/r11127?

comment:9 Changed 5 years ago by Klumbumbus

Resolution: duplicate
Status: newclosed

Closed as duplicate of #13798.
I checked with r11128 from jenkins and I see groups for

  • Role verification problem
  • Presets do not contain property key
  • Presets do not contain property value
  • Missing name:* translation

So all was fixed in r11127. Thanks.

comment:10 Changed 5 years ago by simon04

Thank you for checking r11127 w.r.t. various grouping issues :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.