Modify

Opened 3 years ago

Closed 20 months ago

#13594 closed enhancement (fixed)

[PATCH] update landuse=industrial: add industrial=* combo

Reported by: anonymous Owned by: team
Priority: normal Milestone: 17.08
Component: Internal preset Version:
Keywords: landuse industrial Cc:

Description

This patch extends default preset for

landuse=industrial

by combo

 industrial=*

as defined on wiki: http://wiki.openstreetmap.org/wiki/Key:industrial

Attachments (3)

defaultpreset.xml.patch (881 bytes) - added by Mkyral 3 years ago.
Add industial=* key to landuse=industrial
defaultpresets.xml.patch (858 bytes) - added by Mkyral 2 years ago.
Add combo key="industrial" to landuse=industrial
defaultpresets.xml.industrial.v3.diff (873 bytes) - added by Mkyral 22 months ago.
Add industrial combo, third version

Download all attachments as: .zip

Change History (24)

Changed 3 years ago by Mkyral

Attachment: defaultpreset.xml.patch added

Add industial=* key to landuse=industrial

comment:1 Changed 3 years ago by Mkyral

Summary: Default preset: add industrial=* combo to landuse=industrial[PATCH] Default preset: add industrial=* combo to landuse=industrial

comment:2 Changed 3 years ago by Chrabros

I do not like including both "wellsite" and "well_cluster". IMHO it means the same thing. I would choose only one, probably "wellsite".

comment:3 Changed 3 years ago by Mkyral

I took these values from wiki.

Actually, according to taginfo (http://taginfo.openstreetmap.org/keys/industrial#values):

wellsite     1 920  13.81%
well_cluster 1 179   8.48%

Changed 2 years ago by Mkyral

Attachment: defaultpresets.xml.patch added

Add combo key="industrial" to landuse=industrial

comment:4 Changed 2 years ago by Mkyral

As per comment on wiki, wellsite is more general and well_cluster can contain more wellsites. I've updated the patch - combo values are sorted and spaces were removed.

ps: how can I remove the previous, incorrecly named attachement defaultpreset.xml.patch​? Should be presets.

comment:5 in reply to:  4 ; Changed 2 years ago by skyper

I'd prefer to have the values get more accepted and better documented first. For example, the wiki page for industrial=well_cluster does not contain any sentences at all nor is there any differences between wellsite and well_cluster documented. timber is quite common in use but not documented and the difference to sawmill is unclear.

Can't we start with an individual preset and include it once we have better documentation (especially outlining the differences) and higher numbers of use.

Replying to Mkyral:

ps: how can I remove the previous, incorrecly named attachement defaultpreset.xml.patch​? Should be presets.

If you login, you should be able to delete your attachments.

comment:6 in reply to:  5 ; Changed 2 years ago by Mkyral

Well, I'm not the right person to document it. I'm not a native speaker and I don't know differences between these options :-(
I just want to see industrial=brewery in preset. This should help to increase numbers of use.

Maybe we should keep only some basic set and let rest to be added in future, when all will be clear.

Replying to Mkyral:

ps: how can I remove the previous, incorrecly named attachement defaultpreset.xml.patch​? Should be presets.

If you login, you should be able to delete your attachments.

I'm logged in, but there is no option nor button to delete attachment. I can only add a new one (and replace one with the same name).

comment:7 in reply to:  5 Changed 2 years ago by Mkyral

Replying to skyper:

Can't we start with an individual preset and include it once we have better documentation (especially outlining the differences) and higher numbers of use.

Well, it seems to be the only possibility.
Here we are: https://josm.openstreetmap.de/wiki/Presets/Industrial

comment:8 in reply to:  6 Changed 2 years ago by Klumbumbus

Replying to Mkyral:

Replying to Mkyral:

ps: how can I remove the previous, incorrecly named attachement defaultpreset.xml.patch​? Should be presets.

If you login, you should be able to delete your attachments.

I'm logged in, but there is no option nor button to delete attachment. I can only add a new one (and replace one with the same name).

You can't delete it becasue you need special rights to delete files at the josm website/wiki.

comment:9 Changed 2 years ago by Don-vip

Keywords: landuse industrial added
Summary: [PATCH] Default preset: add industrial=* combo to landuse=industrial[PATCH] update landuse=industrial: add industrial=* combo

comment:10 Changed 2 years ago by bastiK

industrial=* seems worth including in the preset, maybe leave out the values that are redundant or poorly documented?

comment:11 Changed 2 years ago by Mkyral

Good idea. I'll look on it this week.

Changed 22 months ago by Mkyral

Add industrial combo, third version

comment:12 Changed 22 months ago by Mkyral

OK. Third version. I've removed "gas", "well_site", "wellcluster" as undocumented even there are frequently used. I also removed "furniture" and "ice_factory" as both are included in "factory" option.

comment:13 Changed 22 months ago by bastiK

Klumbumbus, any opinion on the updated patch?

comment:14 Changed 22 months ago by Klumbumbus

Milestone: 17.07
Version: latest

Beside the documentation in the wiki the tags should have a decent usage number (see DevelopersGuide/DefaultPresets). I just checked the first one on taginfo: industrial=aluminium_smelting. It is used only twice. Basically I agree to include industrial=* in the default preset, but not the ones with low usage numbers, I would say <100.

comment:15 Changed 22 months ago by Mkyral

Isn't it chicken egg problem? In such case also bakery, shipyard, mine, etc would be omitted. And I don't think there is only 80 big bakeries worldwide.

comment:16 Changed 22 months ago by Klumbumbus

You can tag it regardless of wheather there is a JOSM preset for this tag or not. But we don't need a preset if the users have no interest to tag it.

comment:17 Changed 22 months ago by Mkyral

Yes I can tag it anyway. But I can tag it now as well and users are not doing it. Maybe because they don't know about it or because they don't want spent a too much time with it. If there no right option in preset, user have to search on wiki and maybe he have to use dictionary first, because he don't know the correct english word.

In many cases, user just skip this "additional" tagging to save time and map more.

From myself experience - if preset contains some additional options, I'll check them and try to fill them. But if this option is missing, I'll add additional tags only when I really want it.

comment:18 Changed 22 months ago by bastiK

It may seem silly in this case, but there are users inventing new tagging schemes and trying to get it into the editors before it is accepted by the community. To avoid controversial and later rejected tagging schemes in JOSM, we need to apply a common standard to all requests.

comment:19 Changed 22 months ago by Mkyral

Key:industrial
Status: in use

I have nothing more to say.

If you want, you can eliminate more options (and later on add one by one back). But I'll not do it, I think it is useless.

comment:20 Changed 21 months ago by Don-vip

Milestone: 17.0717.08

i18n impact, moving to next milestone

comment:21 Changed 20 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 12611/josm:

fix #13594 - add industrial=* combo to landuse=industrial preset (modified patch by Mkyral), left out values with tag count <48.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.