Modify

Opened 4 years ago

Closed 9 months ago

#13592 closed defect (fixed)

relation editor: missing repaint of connectivity info after downloading incomplete members

Reported by: skyper Owned by: Don-vip
Priority: normal Milestone: 19.09
Component: Core Version: latest
Keywords: template_report relation editor Cc:

Description

What steps will reproduce the problem?

  1. Have a multipolygon relation with at least one unclosed, incomplete member
  2. Open relation editor and download all incomplete members

What is the expected result?

The connectivity info is updated and I see only closed rings

What happens instead?

The info is not updated and I still see unclosed ways

Please provide any additional information below. Attach a screenshot if possible.

After a click into the relation editor you get the repaint/recalculation.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-08 01:17:53 +0200 (Thu, 08 Sep 2016)
Build-Date:2016-09-08 01:35:41
Revision:10976
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10976 en) Linux Debian GNU/Linux 8.5 (jessie)
Memory Usage: 85 MB / 485 MB (26 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-1~bpo8+1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-8-jre:amd64-8u102-b14.1-1~bpo8+1
Java ATK Wrapper package: libatk-wrapper-java:all-0.30.5-1
VM arguments: [-Djosm.home=<josm.pref>]
Program arguments: [--language=en]

Plugins:
+ OpeningHoursEditor (32699)
+ imagery_offset_db (32796)
+ reverter (32796)
+ tag2link (32941)
+ terracer (32699)
+ undelete (32699)
+ utilsplugin2 (32815)
+ wikipedia (32884)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ http://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Simple_Indoor_Tagging&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Attachments (4)

josm_13592_example.osm (7.2 KB) - added by skyper 4 years ago.
example file
josm_13592_before_screen.png (10.4 KB) - added by skyper 4 years ago.
first screenshot
josm_13592_after_screen.png (8.6 KB) - added by skyper 4 years ago.
second screenshot
josm_13592_final_screen.png (10.3 KB) - added by skyper 4 years ago.
third screenshot

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by skyper

Version: latest

comment:2 Changed 4 years ago by GerdP

I would only expect this when the order of the members is sorted so that the members form closed rings. Was that the case?

comment:3 in reply to:  2 ; Changed 4 years ago by skyper

Replying to Gerd Petermann <gpetermann_muenchen@…>:

I would only expect this when the order of the members is sorted so that the members form closed rings. Was that the case?

Yes, this was a simple, complete and ordered multipolygon. Two outer and two inner ways and one outer way was incomplete. After downloading I clicked on the member list and the hint was updated. Gonna try to make an example file.

Changed 4 years ago by skyper

Attachment: josm_13592_example.osm added

example file

Changed 4 years ago by skyper

first screenshot

Changed 4 years ago by skyper

Attachment: josm_13592_after_screen.png added

second screenshot

Changed 4 years ago by skyper

Attachment: josm_13592_final_screen.png added

third screenshot

comment:4 in reply to:  3 Changed 4 years ago by skyper

Replying to skyper:

Gonna try to make an example file.

See josm_13592_example.osm

Starting situation:
first screenshot

After download:
second screenshot

After clicks on both outer members:
third screenshot

comment:5 Changed 4 years ago by GerdP

Yes, can reproduce it with your example. It works fine when you open a new layer, download one way of the MP and then download the incomplete others. Sorry, no idea where this has to be fixed :-(

comment:6 Changed 3 years ago by Don-vip

Priority: minornormal

comment:7 Changed 9 months ago by Don-vip

Milestone: 19.09
Owner: changed from team to Don-vip
Status: newassigned

comment:8 Changed 9 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15378/josm:

fix #13592 - refresh relation member table connectivity after a change of member ways nodes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.