DataIntegrityProblemException at PTAssistantPaintVisitor.drawStopLabel

[skyper]

What steps will reproduce the problem?

1. Select almost all downloaded data except of a stop and some nodes
2. purge selected

What is the expected result?

All objects except of the few disappear

What happens instead?

DataIntegrityProblemException

Please provide any additional information below. Attach a screenshot if possible.

Purge did ask me about additional purging a pt route releation in advance of the NPE.

Think this is cause by the plugin "pt assistance" but JOSM does not report it.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-03 03:27:18 +0200 (Sat, 03 Sep 2016)
Build-Date:2016-09-03 01:37:36
Revision:10936
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10936 en) Linux Debian GNU/Linux 8.5 (jessie)
Memory Usage: 512 MB / 882 MB (249 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-1~bpo8+1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1440x900
Maximum Screen Size: 1440x900
Java package: openjdk-8-jre:amd64-8u102-b14.1-1~bpo8+1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Djosm.home=<josm.pref>]
Program arguments: [--language=en, save.osm]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (32699)
+ imagery_offset_db (32796)
+ imageryadjust (32699)
+ indoorhelper (32680)
+ pt_assistant (32895)
+ reverter (32796)
+ terracer (32699)
+ undelete (32699)
+ utilsplugin2 (32815)
+ wikipedia (32884)

Tagging presets:
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ http://osmtools.de/josm/steps.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet


=== REPORTED CRASH DATA ===
MapView#paintLayer:
 - layer: org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantLayer@4a193cb4
 - bounds: Bounds[47.9999779,7.8321188,48.000651,7.8335391]

Warning issued by: MapView#paintLayer

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (18) of main
org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=31683485 version=15 VT lat=48.0035186,lon=7.836305}
	at org.openstreetmap.josm.data.osm.OsmPrimitive.checkDataset(OsmPrimitive.java:373)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:1098)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:1119)
	at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantPaintVisitor.drawStopLabel(PTAssistantPaintVisitor.java:336)
	at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantPaintVisitor.visit(PTAssistantPaintVisitor.java:104)
	at org.openstreetmap.josm.data.osm.Relation.accept(Relation.java:164)
	at org.openstreetmap.josm.data.validation.PaintVisitor.visit(PaintVisitor.java:109)
	at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantLayer.paint(PTAssistantLayer.java:142)
	at org.openstreetmap.josm.gui.layer.AbstractMapViewPaintable$CompatibilityModeLayerPainter.paint(AbstractMapViewPaintable.java:27)
	at org.openstreetmap.josm.gui.MapView.paintLayer(MapView.java:843)
	at org.openstreetmap.josm.gui.MapView.paint(MapView.java:935)
	at javax.swing.JComponent.paintChildren(JComponent.java:889)
	at javax.swing.JComponent.paint(JComponent.java:1065)
	at javax.swing.JComponent.paintToOffscreen(JComponent.java:5210)
	at javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:290)
	at javax.swing.RepaintManager.paint(RepaintManager.java:1272)
	at javax.swing.JComponent._paintImmediately(JComponent.java:5158)
	at javax.swing.JComponent.paintImmediately(JComponent.java:4969)
	at javax.swing.RepaintManager$4.run(RepaintManager.java:831)
	at javax.swing.RepaintManager$4.run(RepaintManager.java:814)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:814)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:789)
	at javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:738)
	at javax.swing.RepaintManager.access$1200(RepaintManager.java:64)
	at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1732)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[skyper]

The purging did work but now I get the NPE on every repaint of the map.

[skyper]

Oh it is the pt assistance as once I delete its layer the NPE is gone

[Klumbumbus]

The plugin is also listed in the stack trace:

...
at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantPaintVisitor.drawStopLabel(PTAssistantPaintVisitor.java:336)
at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantPaintVisitor.visit(PTAssistantPaintVisitor.java:104)
...
at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantLayer.paint(PTAssistantLayer.java:142)
...

[skyper]

Replying to Klumbumbus:

The plugin is also listed in the stack trace:

...
at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantPaintVisitor.drawStopLabel(PTAssistantPaintVisitor.java:336)
at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantPaintVisitor.visit(PTAssistantPaintVisitor.java:104)
...
at org.openstreetmap.josm.plugins.pt_assistant.gui.PTAssistantLayer.paint(PTAssistantLayer.java:142)
...

Yes, but JOSM does not detect it (should set the component automatically) and I miss the dialog to disable the plugin.

[darya]

Thanks for reporting the bug. I haven't been able to reproduce it so far. Does it occur with a particular dataset? If so, could you upload it here?

If not, I need a little help: do I have to leave a stop_area relation unselected (and therefore excluded from purge)? Can it be a route relation?

[skyper]

Replying to darya:

I haven't been able to reproduce it so far. Does it occur with a particular dataset? If so, could you upload it here?

I did occur when I did create the example file​ for #13521. The download area should be still visible. And I had a pt-layer open

If not, I need a little help: do I have to leave a stop_area relation unselected (and therefore excluded from purge)? Can it be a route relation?

Yes, I did at least have one stop_area relation unselected and I propably did purge route relations which where rendered in the pt-layer.

[darya]

Replying to skyper:
Thanks for the explanation. Still, can't reproduce the problem.

I've opened the example file in JOSM,
downloaded the OSM data for this area,
selected some routes (so that the pt_assistant layer becomes activated),
purged everything except for the stop_area relations,
pressed the "Validation" button,
got no exception.

I'll have to look more into what may be causing the DataIntegrityProblemException

[skyper]

Replying to darya:

Replying to skyper:
Thanks for the explanation. Still, can't reproduce the problem.

I've opened the example file in JOSM,
downloaded the OSM data for this area,
selected some routes (so that the pt_assistant layer becomes activated),
purged everything except for the stop_area relations,
pressed the "Validation" button,
got no exception.

I'll have to look more into what may be causing the DataIntegrityProblemException

Got this exception right after purging and I did run validator before purging not after.

[skyper]

Similar to #7170

[Don-vip]

Ticket #15763 has been marked as a duplicate of this ticket.