Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13521 closed defect (fixed)

False validator warning with incomplete members

Reported by: skyper Owned by: darya
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: template_report validator incomplete Cc:

Description

What steps will reproduce the problem?

  1. Have an incomplete downloaded stop area relation without any platform downloaded.
  2. run validator

What is the expected result?

No warning as stop area relation has incomplete members with role platform

What happens instead?

Warning about "stop area relation does not have any platform as memeber.

Please provide any additional information below. Attach a screenshot if possible.

Please check for roles and validate complete objects if the fit the roles.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-03 03:27:18 +0200 (Sat, 03 Sep 2016)
Build-Date:2016-09-03 01:37:36
Revision:10936
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10936 en) Linux Debian GNU/Linux 8.5 (jessie)
Memory Usage: 510 MB / 882 MB (286 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-1~bpo8+1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1440x900
Maximum Screen Size: 1440x900
Java package: openjdk-8-jre:amd64-8u102-b14.1-1~bpo8+1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Djosm.home=<josm.pref>]
Program arguments: [--language=en, save.osm]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (32699)
+ imagery_offset_db (32796)
+ imageryadjust (32699)
+ indoorhelper (32680)
+ pt_assistant (32895)
+ reverter (32796)
+ terracer (32699)
+ undelete (32699)
+ utilsplugin2 (32815)
+ wikipedia (32884)

Tagging presets:
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ http://osmtools.de/josm/steps.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet

Attachments (1)

josm_13521_example.osm (31.7 KB) - added by skyper 5 years ago.
example file

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by skyper

All the validator warnings seem not to work with incomplete data. See my attached example file.

Changed 5 years ago by skyper

Attachment: josm_13521_example.osm added

example file

comment:2 Changed 5 years ago by darya

Resolution: fixed
Status: newclosed

I've changed the code so that the tests for the stop_area relations only run if the relation does not have incomplete members. I think this should fix the problem. Please update the plugin to version 32963 or later.

Thanks for reporting the bug!

comment:3 Changed 5 years ago by skyper

For the role checks you do not need all members but you need to check the roles within the relation and not the members themselves.

comment:4 Changed 5 years ago by darya

This test checks the tags of the relation member, not the relation member roles. This way, if the relation member has the correct role but its tags are wrong, this results in a warning.

For the plugin to be able to check the tags, the relation has to be complete.

So I haven't changed the code here. However, I updated the definition of the tags that are required for a platform. Before, a primitive was a platform if it had the tag
public_transport=platform

Now, I've also added the tags:
highway=bus_stop
highway=platform
railway=platform

The new version is 32990.

Last edited 5 years ago by darya (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain darya.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.