Modify

Opened 2 years ago

Last modified 15 months ago

#13518 new defect

Inner outer ring check is not promted as frequently as it should

Reported by: openstreetmap.org-user-d1g Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: multipolygon Cc: GerdP

Description (last modified by Don-vip)

From Valid Multipolygon conditions:

  1. Inner polygons must not overlap with outer polygons or touch them.

There multiple issues with this video:

  1. validation is not triggered at the first attempt, I have to move objects and also to deselect an inner ring
  2. text label is not precise. Please change text to "outer and inner rings of the multi-polygon shouldn't have a common nodes"

Movie(MP inner outer check.mp4)?

PS. I started work on multipolygon tools, expect many reports and obscure bugs :)

Attachments (3)

MP inner outer check.mp4 (1.4 MB) - added by openstreetmap.org-user-d1g 2 years ago.
touching inner and outer rings.joz (1.0 KB) - added by openstreetmap.org-user-d1g 2 years ago.
inner_ring_intersect.osm (36.3 KB) - added by Vort_ 2 years ago.

Download all attachments as: .zip

Change History (17)

Changed 2 years ago by openstreetmap.org-user-d1g

Attachment: MP inner outer check.mp4 added

Changed 2 years ago by openstreetmap.org-user-d1g

comment:1 Changed 2 years ago by openstreetmap.org-user-d1g

Description: modified (diff)

comment:2 Changed 2 years ago by openstreetmap.org-user-d1g

Description: modified (diff)

comment:3 Changed 2 years ago by openstreetmap.org-user-d1g

If you play with inner ring more by just slightly placing it, this validation check work roughly every 2 time. I don't have explanation why or exact steps when.

comment:4 Changed 2 years ago by openstreetmap.org-user-d1g

Component: CoreCore validator

comment:5 Changed 2 years ago by Don-vip

Description: modified (diff)

comment:6 Changed 2 years ago by Don-vip

Cc: GerdP added

@Gerd: is it fixed in #13165 patch?

comment:9 in reply to:  6 Changed 2 years ago by GerdP

Replying to Don-vip:

@Gerd: is it fixed in #13165 patch?

No, this patch only detects intersections between different mp-relations. I've provided a patch for this problem with patches in #13307 and #13086.

Changed 2 years ago by Vort_

Attachment: inner_ring_intersect.osm added

comment:10 Changed 2 years ago by Vort_

The same thing happens with inner-inner intersections.
If you load "inner_ring_intersect.osm", then click "Validation" button, error appears.
But if you then select any inner ring and re-run validation, no errors will be shown.

comment:11 in reply to:  10 Changed 2 years ago by GerdP

Replying to Vort_:

But if you then select any inner ring and re-run validation, no errors will be shown.

Not sure, but I think this is intended. If you select the inner way then only this way is validated. The relation is ignored
as it is not in the list of selected items.

comment:12 Changed 2 years ago by Vort_

Turns out that deselection part of this report is not a problem.
Thanks for clarification.

Last edited 2 years ago by Vort_ (previous) (diff)

comment:13 Changed 2 years ago by GerdP

Do you use my patches for your tests? I am thinking about a complete rewrite of the existing Multipolyogn code in JOSM, but I am not sure yet as the code seems to support some old style multipolygons which are no longer documented in the wiki at
http://wiki.openstreetmap.org/wiki/Relation:multipolygon
For example, it seems to handle heavily nested mp with inner inside outer inside inner inside outer and so on. I did not find a real world example for this yet, but the JOSM source contains core\data_nodist\multipolygon.osm which has a few samples of this
e.g. "Example 8 (01)"

comment:14 Changed 15 months ago by Don-vip

Keywords: multipolygon added; multipolygons removed

comment:15 Changed 15 months ago by GerdP

@Vort_ : I assume the problems are already fixed with r11227. Can we close this ticket?

comment:16 Changed 15 months ago by Vort_

I'm not the author of this report.
My problem was just with misunderstanding of JOSM behaviour.
And that is really "fixed" :)

I did not tested other parts of this report.
And don't know what is their state now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to openstreetmap.org-user-d1g
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.