Inner outer ring check is not promted as frequently as it should

[openstreetmap.org-user-d1g]

From ​Valid Multipolygon conditions:

3. Inner polygons must not overlap with outer polygons or touch them.

There multiple issues with this video:

1. validation is not triggered at the first attempt, I have to move objects and also to deselect an inner ring
2. text label is not precise. Please change text to "outer and inner rings of the multi-polygon shouldn't have a common nodes"

Movie(MP inner outer check.mp4)

PS. I started work on multipolygon tools, expect many reports and obscure bugs :)

[openstreetmap.org-user-d1g]

If you play with inner ring more by just slightly placing it, this validation check work roughly every 2 time. I don't have explanation why or exact steps when.

[Don-vip]

@Gerd: is it fixed in #13165 patch?

[GerdP]

Replying to Don-vip:

@Gerd: is it fixed in #13165 patch?

No, this patch only detects intersections between different mp-relations. I've provided a patch for this problem with patches in #13307 and #13086.

[Vort_]

The same thing happens with inner-inner intersections.
If you load "inner_ring_intersect.osm", then click "Validation" button, error appears.
But if you then select any inner ring and re-run validation, no errors will be shown.

[GerdP]

Replying to Vort_:

But if you then select any inner ring and re-run validation, no errors will be shown.

Not sure, but I think this is intended. If you select the inner way then only this way is validated. The relation is ignored
as it is not in the list of selected items.

[Vort_]

Turns out that deselection part of this report is not a problem.
Thanks for clarification.

[GerdP]

Do you use my patches for your tests? I am thinking about a complete rewrite of the existing Multipolyogn code in JOSM, but I am not sure yet as the code seems to support some old style multipolygons which are no longer documented in the wiki at
​http://wiki.openstreetmap.org/wiki/Relation:multipolygon
For example, it seems to handle heavily nested mp with inner inside outer inside inner inside outer and so on. I did not find a real world example for this yet, but the JOSM source contains core\data_nodist\multipolygon.osm which has a few samples of this
e.g. "Example 8 (01)"

[GerdP]

@Vort_ : I assume the problems are already fixed with r11227. Can we close this ticket?

[Vort_]

I'm not the author of this report.
My problem was just with misunderstanding of JOSM behaviour.
And that is really "fixed" :)

I did not tested other parts of this report.
And don't know what is their state now.

[GerdP]

probably fixed with r11227