[Patch] improve performance in Renderer

[GerdP]

I've noticed that MatchingReferrerFinder.visit(Way w) is using a sequential search through all way nodes to find the index of the node. This index is only used when the corresponding style rule uses it, in the default file elemstyles.mapcss no rule uses it. The same seq. search is done for members of relations, and again, no default rule uses this. I've created a quick hack which avoids the search when the only information that is needed is whether the parent way (relation) matches.

I guess a cleaner solution would be to add a boolean field indexNeeded in the selector which would be set when the rule contains the index clause (or the role clause).
I leave that to the experts.

[GerdP]

Sorry, one relation rule needs it:

relation[type=enforcement] >[role="device"] node {
    icon-image: "presets/vehicle/restriction/speed_camera.svg";
    set icon_z17;
}

So the search is needed in rare cases, but executed quite often, e.g. for this rule.

way > node[!setting("shrink_nodes")]            { symbol-size: 4; }

The index is not needed, we just want to know if the node is member of a way.

[Don-vip]

In 10882/josm:

fix #13396 - improve performance in Renderer (patch by Gerd Petermann, modified to remove code duplication, using Java 8 int functions)

[GerdP]

BTW: This also improves performance of the Validator (Tag Checker) a bit.